Skip to content

Conversation

andreasgerstmayr
Copy link
Contributor

@andreasgerstmayr andreasgerstmayr commented Sep 8, 2025

Upgrade Perses to v0.52.0-rc.1, with the following new features:

Trace ID, Span ID, Timings

image

Span Links

image

Escaped TraceQL auto-complete

image

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 8, 2025
Copy link

openshift-ci bot commented Sep 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 8, 2025

@andreasgerstmayr: This pull request references TRACING-5604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Upgrade Perses to v0.52.0-rc.0, with the following new features:

Trace ID, Span ID, Timings

image

Span Links

image

Escaped TraceQL auto-complete

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2025
@andreasgerstmayr andreasgerstmayr marked this pull request as ready for review September 9, 2025 18:05
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2025
@andreasgerstmayr andreasgerstmayr changed the title TRACING-5604: Upgrade Perses to v0.52.0-rc.0 TRACING-5604: Upgrade Perses to v0.52.0-rc.1 Sep 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 9, 2025

@andreasgerstmayr: This pull request references TRACING-5604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Upgrade Perses to v0.52.0-rc.1, with the following new features:

Trace ID, Span ID, Timings

image

Span Links

image

Escaped TraceQL auto-complete

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@IshwarKanse
Copy link
Member

/retest

@PeterYurkovich
Copy link
Contributor

/lgtm

I know you are likely looking to resolve the conflicting packages, so if you need another review just ping me again

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2025
@IshwarKanse
Copy link
Member

@andreasgerstmayr I built the plugin image from the PR quay.io/rhn_support_ikanse/distributed-tracing-console-plugin:latest and verified the features. Apart from the span links, rest of the features are working as expected. In my test env, I don't see the span links. OCP cluster version is 4.19.0-0.nightly-2025-09-14-165440, Patched the built Tracing UI plugin image in cluster-observability-operator.v1.2.2 CSV.

Screenshot 2025-09-15 at 11 11 57 AM

@andreasgerstmayr
Copy link
Contributor Author

In my test env, I don't see the span links.

The span links tab is only shown when a span has span links. Does the selected span have links? Can you download the trace and attach it, so I can check?

For my own testing I used https://github.com/andreasgerstmayr/deployments/tree/main/src/tracegen to generate traces with span links.

@IshwarKanse
Copy link
Member

@andreasgerstmayr I have used the Jaeger's Hot Riders on Demand app. Here is the exported trace.
075465A0626B8EFF2268CE54A6A7F905.json I'll try with the trace generator which has links like you mentioned.

@IshwarKanse
Copy link
Member

@andreasgerstmayr Tested the span links, permalinks as well for selecting a span. I modified the telemetrygen tool code to add support for span links using Claude. It is working well. open-telemetry/opentelemetry-collector-contrib@main...IshwarKanse:opentelemetry-collector-contrib:spanlinks Will raise a PR in the contrib after some refinements. :D

QE is completed for this PR.

Upgrade Perses to v0.52.0-rc.1, with the following new features:
* span links, permalink for selecting a span (https://issues.redhat.com/browse/TRACING-5390)
* button to download trace as OTLP/JSON (https://issues.redhat.com/browse/TRACING-5578)
* show trace id and span id in gantt chart (https://issues.redhat.com/browse/OU-873)
* add span timestamp and duration (https://issues.redhat.com/browse/OU-926)
* fix quoting in TraceQL auto-completion, support backticks (https://issues.redhat.com/browse/COO-1175)

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2025
@IshwarKanse
Copy link
Member

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 15, 2025

@andreasgerstmayr: This pull request references TRACING-5604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Upgrade Perses to v0.52.0-rc.1, with the following new features:

Trace ID, Span ID, Timings

image

Span Links

image

Escaped TraceQL auto-complete

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@IshwarKanse
Copy link
Member

/override ci/prow/upstream-amd64-aws-e2e ci/prow/upstream-amd64-aws-images ci/prow/upstream-amd64-aws-fips-image-scan

@IshwarKanse
Copy link
Member

I'll look into the CI issue and update the tests as well.

Copy link

openshift-ci bot commented Sep 15, 2025

@IshwarKanse: Overrode contexts on behalf of IshwarKanse: ci/prow/upstream-amd64-aws-e2e, ci/prow/upstream-amd64-aws-fips-image-scan, ci/prow/upstream-amd64-aws-images

In response to this:

/override ci/prow/upstream-amd64-aws-e2e ci/prow/upstream-amd64-aws-images ci/prow/upstream-amd64-aws-fips-image-scan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@PeterYurkovich
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2025
Copy link

openshift-ci bot commented Sep 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreasgerstmayr, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,andreasgerstmayr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IshwarKanse
Copy link
Member

Bumped the resources for the CI jobs. openshift/release#69301

@IshwarKanse
Copy link
Member

/retest

@IshwarKanse
Copy link
Member

/test all

Copy link

openshift-ci bot commented Sep 16, 2025

@andreasgerstmayr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fkargbo
Copy link

fkargbo commented Sep 16, 2025

/label ux-approved

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label Sep 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 409e11d into openshift:main Sep 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants