-
Notifications
You must be signed in to change notification settings - Fork 8
TRACING-5604: Upgrade Perses to v0.52.0-rc.1 #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRACING-5604: Upgrade Perses to v0.52.0-rc.1 #149
Conversation
Skipping CI for Draft Pull Request. |
@andreasgerstmayr: This pull request references TRACING-5604 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f7a74ff
to
60f2732
Compare
60f2732
to
1473a7a
Compare
@andreasgerstmayr: This pull request references TRACING-5604 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
/lgtm I know you are likely looking to resolve the conflicting packages, so if you need another review just ping me again |
@andreasgerstmayr I built the plugin image from the PR quay.io/rhn_support_ikanse/distributed-tracing-console-plugin:latest and verified the features. Apart from the span links, rest of the features are working as expected. In my test env, I don't see the span links. OCP cluster version is 4.19.0-0.nightly-2025-09-14-165440, Patched the built Tracing UI plugin image in cluster-observability-operator.v1.2.2 CSV. ![]() |
The span links tab is only shown when a span has span links. Does the selected span have links? Can you download the trace and attach it, so I can check? For my own testing I used https://github.com/andreasgerstmayr/deployments/tree/main/src/tracegen to generate traces with span links. |
@andreasgerstmayr I have used the Jaeger's Hot Riders on Demand app. Here is the exported trace. |
@andreasgerstmayr Tested the span links, permalinks as well for selecting a span. I modified the telemetrygen tool code to add support for span links using Claude. It is working well. open-telemetry/opentelemetry-collector-contrib@main...IshwarKanse:opentelemetry-collector-contrib:spanlinks Will raise a PR in the contrib after some refinements. :D QE is completed for this PR. |
Upgrade Perses to v0.52.0-rc.1, with the following new features: * span links, permalink for selecting a span (https://issues.redhat.com/browse/TRACING-5390) * button to download trace as OTLP/JSON (https://issues.redhat.com/browse/TRACING-5578) * show trace id and span id in gantt chart (https://issues.redhat.com/browse/OU-873) * add span timestamp and duration (https://issues.redhat.com/browse/OU-926) * fix quoting in TraceQL auto-completion, support backticks (https://issues.redhat.com/browse/COO-1175) Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
1473a7a
to
3f57732
Compare
/label qe-approved |
@andreasgerstmayr: This pull request references TRACING-5604 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/override ci/prow/upstream-amd64-aws-e2e ci/prow/upstream-amd64-aws-images ci/prow/upstream-amd64-aws-fips-image-scan |
I'll look into the CI issue and update the tests as well. |
@IshwarKanse: Overrode contexts on behalf of IshwarKanse: ci/prow/upstream-amd64-aws-e2e, ci/prow/upstream-amd64-aws-fips-image-scan, ci/prow/upstream-amd64-aws-images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreasgerstmayr, PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bumped the resources for the CI jobs. openshift/release#69301 |
/retest |
/test all |
@andreasgerstmayr: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label ux-approved |
Upgrade Perses to v0.52.0-rc.1, with the following new features:
Trace ID, Span ID, Timings
Span Links
Escaped TraceQL auto-complete