Skip to content

Align distinguished name (DN) of the certificate generated by EO with CLO #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2022
Merged

Align distinguished name (DN) of the certificate generated by EO with CLO #832

merged 1 commit into from
Jan 21, 2022

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Jan 20, 2022 •
edited
Loading

Signed-off-by: Vitalii Parfonov vparfonov@redhat.com

Description

/cc
/assign @jcantrill

/cherry-pick

Links

@vparfonov
Align distinguished name (DN) of the certificate with CLO
e1bdf5c 
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2022
@openshift-ci openshift-ci bot requested review from alanconway and shwetaap January 20, 2022 12:36
@vparfonov vparfonov marked this pull request as ready for review January 20, 2022 14:05
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2022
@vparfonov vparfonov changed the title Align distinguished name (DN) of the certificate with CLO Align distinguished name (DN) of the certificate generated by EO with CLO Jan 20, 2022
@vparfonov vparfonov mentioned this pull request Jan 20, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sasagarw
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2022
@jcantrill
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022
@openshift-merge-robot openshift-merge-robot merged commit eea7a27 into openshift:master Jan 21, 2022
@vparfonov vparfonov deleted the alignDN branch January 21, 2022 16:15
alanconway
alanconway reviewed Jan 21, 2022
View reviewed changes
Copy link
Contributor

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwetaap shwetaap Awaiting requested review from shwetaap

1 more reviewer

@alanconway alanconway alanconway left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sasagarw sasagarw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vparfonov @sasagarw @jcantrill @alanconway @openshift-merge-robot