Skip to content

Conversation

aminesnow
Copy link
Contributor

@aminesnow aminesnow commented Jul 20, 2022

Description

Update to use Go 1.18 and k8s client to 0.24.3.

/cc @periklis
/assign @periklis

Links

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2022
@openshift-ci openshift-ci bot requested a review from periklis July 20, 2022 10:29
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Remember you need to update also the upstream CI to get the builders/tests pass here https://github.com/openshift/release/blob/master/ci-operator/config/openshift/elasticsearch-operator/openshift-elasticsearch-operator-master.yaml#L1-L72:

  • Base images should go up to 4.11
  • RHEL8 Golang builder should be 1.18 from 4.11

Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's put this in "ready for review" to let CI give it's testimonials.

@aminesnow aminesnow marked this pull request as ready for review July 20, 2022 17:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2022
@periklis
Copy link
Contributor

/approve

Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting CI verdict

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aminesnow, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
@Red-GV
Copy link
Contributor

Red-GV commented Jul 20, 2022

/retest

@Red-GV
Copy link
Contributor

Red-GV commented Jul 20, 2022

Looks good. @aminesnow, please squash commits.

@aminesnow
Copy link
Contributor Author

Looks good. @aminesnow, please squash commits.

Done.

@periklis
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2022
@periklis
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2022

@aminesnow: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 870242e into openshift:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants