Bug 2060968: Add delay between ironic-agent restart, but restart forever

[elfosardo]

With this change, if the ironic-agent fails, it will restart forever,
until success. Adds 5 seconds between each restart attempt to avoid
spamming the system.

[openshift-ci]

@elfosardo: This pull request references Bugzilla bug 2060968, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (lshilin@redhat.com), skipping review request.

In response to this:

Bug 2060968: Add delay between ironic-agent restart, but restart forever

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elfosardo]

/cc @bfournie

[elfosardo]

/test e2e-metal-ipi-serial-ipv4

[bfournie]

/lgtm

[elfosardo]

/test e2e-metal-ipi

[openshift-ci]

@elfosardo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[honza]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [honza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@elfosardo: All pull requests linked via external trackers have merged:

• openshift/image-customization-controller#34
• openshift/image-customization-controller#51

Bugzilla bug 2060968 has been moved to the MODIFIED state.

In response to this:

Bug 2060968: Add delay between ironic-agent restart, but restart forever

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elfosardo]

/cherry-pick release-4.10

[openshift-cherrypick-robot]

@elfosardo: #51 failed to apply on top of branch "release-4.10":

Applying: Add delay between ironic-agent restart, but restart forever
Using index info to reconstruct a base tree...
M	pkg/ignition/service_config.go
M	pkg/ignition/service_config_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/ignition/service_config_test.go
CONFLICT (content): Merge conflict in pkg/ignition/service_config_test.go
Auto-merging pkg/ignition/service_config.go
CONFLICT (content): Merge conflict in pkg/ignition/service_config.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add delay between ironic-agent restart, but restart forever
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elfosardo]

we'll backport after #43

[elfosardo]

/cherry-pick release-4.10

[openshift-cherrypick-robot]

@elfosardo: #51 failed to apply on top of branch "release-4.10":

Applying: Add delay between ironic-agent restart, but restart forever
Using index info to reconstruct a base tree...
M	pkg/ignition/service_config.go
M	pkg/ignition/service_config_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/ignition/service_config_test.go
CONFLICT (content): Merge conflict in pkg/ignition/service_config_test.go
Auto-merging pkg/ignition/service_config.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add delay between ironic-agent restart, but restart forever
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elfosardo]

alright, I'll backport it manually