OCPBUGS-4465: Log message if nmstate output is '--- {}\n' #72

k37y · 2022-12-05T06:52:15Z

Even if the nmstate data is incorrect, the metal3 customized image builds and boots up without the network.

$ oc rsh metal3-image-customization-76ccc78d59-wzjm7
sh-4.4# cat << EOF | nmstatectl gc -
foo:
  bar: baz
EOF
--- {}

openshift-ci-robot · 2022-12-05T06:52:38Z

@kevydotvinu: This pull request references Jira Issue OCPBUGS-4465, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If the nmstate data is incorrect, an image is built and boots up with no static IP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-12-05T09:39:20Z

@kevydotvinu: This pull request references Jira Issue OCPBUGS-4465, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

If the nmstate data is incorrect, an image is built and boots up with no static IP.
$ cat << EOF | nmstatectl gc -
foo:
 bar: baz
EOF
--- {}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-12-05T09:40:23Z

@kevydotvinu: This pull request references Jira Issue OCPBUGS-4465, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

If the nmstate data is incorrect, the metal3 customized image builds and boots up without static IP.
$ cat << EOF | nmstatectl gc -
foo:
 bar: baz
EOF
--- {}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-12-05T09:41:03Z

@kevydotvinu: This pull request references Jira Issue OCPBUGS-4465, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

If the nmstate data is incorrect, the metal3 customized image builds and boots up without the network.
$ cat << EOF | nmstatectl gc -
foo:
 bar: baz
EOF
--- {}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-12-05T09:47:09Z

@kevydotvinu: This pull request references Jira Issue OCPBUGS-4465, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

If the nmstate data is incorrect, the metal3 customized image builds and boots up without the network.
$ cat << EOF | nmstatectl gc -
foo:
 bar: baz
EOF
$ --- {}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-12-05T09:47:29Z

@kevydotvinu: This pull request references Jira Issue OCPBUGS-4465, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

If the nmstate data is incorrect, the metal3 customized image builds and boots up without the network.
$ cat << EOF | nmstatectl gc -
foo:
 bar: baz
EOF
--- {}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-12-05T10:12:45Z

@kevydotvinu: This pull request references Jira Issue OCPBUGS-4465, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

If the nmstate data is incorrect, the metal3 customized image builds and boots up without the network.
$ oc rsh metal3-image-customization-76ccc78d59-wzjm7
sh-4.4# cat << EOF | nmstatectl gc -
foo:
 bar: baz
EOF
--- {}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-12-05T12:12:46Z

@kevydotvinu: This pull request references Jira Issue OCPBUGS-4465, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Even if the nmstate data is incorrect, the metal3 customized image builds and boots up without the network.
$ oc rsh metal3-image-customization-76ccc78d59-wzjm7
sh-4.4# cat << EOF | nmstatectl gc -
foo:
 bar: baz
EOF
--- {}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dtantsur · 2022-12-05T14:00:48Z

pkg/ignition/builder.go

@@ -73,6 +73,9 @@ func (b *ignitionBuilder) ProcessNetworkState() (error, string) {
 			}
 			return err, ""
 		}
+		if string(out) == "--- {}\n" {
+			return nil, "no network configuration file(s): " + string(out)


No point to add string(out) to the message: it does not provide any details

ack @dtantsur. I will make the change. And will the no network configuration file(s) be the appropriate message here?

If we cannot add anything more useful - yes. Does it log any errors to stderr though?

Hello @dtantsur, no stderr. Hence I have changed the message to no network configuration. Please review and let me know if anything needs to be added.

dtantsur · 2022-12-05T14:01:09Z

pkg/ignition/builder.go

@@ -73,6 +73,9 @@ func (b *ignitionBuilder) ProcessNetworkState() (error, string) {
 			}
 			return err, ""
 		}
+		if string(out) == "--- {}\n" {


Do you want to add the same to GenerateConfig? Maybe even extracted to a helper function?

When I tested without the GenerateConfig change, I could see the below and it was working. However, I will add that there.

$ oc logs -f deployment/metal3 -c metal3-baremetal-operator ... {"level":"info","ts":1670250809.4937377,"logger":"controllers.BareMetalHost","msg":"registering and validating access to management controller","baremetalhost":"openshift-machine-api/openshift-worker-0","provisioningState":"inspecting","credentials":{"credentials":{"name":"openshift-worker-0-bmc-secret","namespace":"openshift-machine-api"},"credentialsVersion":"1251268"}} {"level":"info","ts":1670250809.4938302,"logger":"controllers.BareMetalHost","msg":"error building PreprovisioningImage","baremetalhost":"openshift-machine-api/openshift-worker-0","provisioningState":"inspecting","message":"Cannot generate image: no network configuration file(s): --- {}\n"} {"level":"info","ts":1670250809.4938524,"logger":"controllers.BareMetalHost","msg":"saving host status","baremetalhost":"openshift-machine-api/openshift-worker-0","provisioningState":"inspecting","operational status":"error","provisioning state":"inspecting"} {"level":"info","ts":1670250809.5001462,"logger":"controllers.BareMetalHost","msg":"publishing event","baremetalhost":"openshift-machine-api/openshift-worker-0","reason":"RegistrationError","message":"Cannot generate image: no network configuration file(s): --- {}\n"} ...

$ oc logs -f deployment/metal3-image-customization ... {"level":"info","ts":1670250809.3059509,"logger":"controllers.PreprovisioningImage","msg":"updating status","preprovisioningimage":"openshift-machine-api/openshift-worker-0"} {"level":"info","ts":1670250809.6846116,"logger":"controllers.PreprovisioningImage","msg":"image build failed","preprovisioningimage":"openshift-machine-api/openshift-worker-0","error":"err"} {"level":"info","ts":1670250809.6887758,"logger":"controllers.PreprovisioningImage","msg":"updating status","preprovisioningimage":"openshift-machine-api/openshift-worker-0"} {"level":"info","ts":1670250810.077957,"logger":"controllers.PreprovisioningImage","msg":"image build failed","preprovisioningimage":"openshift-machine-api/openshift-worker-0","error":"err"} {"level":"info","ts":1670250810.0780048,"logger":"controllers.PreprovisioningImage","msg":"updating status","preprovisioningimage":"openshift-machine-api/openshift-worker-0"} ...

dtantsur · 2022-12-05T14:01:24Z

/jira refresh

openshift-ci-robot · 2022-12-05T14:01:31Z

@dtantsur: This pull request references Jira Issue OCPBUGS-4465, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @pamoedom

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-03-06T01:00:53Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

k37y · 2023-03-06T02:19:36Z

/remove-lifecycle stale

openshift-ci · 2023-05-02T17:28:42Z

@kevydotvinu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dtantsur · 2023-05-03T07:08:48Z

/approve

openshift-ci · 2023-05-03T07:09:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, kevydotvinu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

elfosardo · 2023-05-05T07:49:45Z

/lgtm

openshift-ci-robot · 2023-05-05T07:53:35Z

@kevydotvinu: Jira Issue OCPBUGS-4465: All pull requests linked via external trackers have merged:

openshift/image-customization-controller#72

Jira Issue OCPBUGS-4465 has been moved to the MODIFIED state.

In response to this:

Even if the nmstate data is incorrect, the metal3 customized image builds and boots up without the network.
$ oc rsh metal3-image-customization-76ccc78d59-wzjm7
sh-4.4# cat << EOF | nmstatectl gc -
foo:
 bar: baz
EOF
--- {}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from hardys and sadasu December 5, 2022 06:52

k37y changed the title ~~Log message if nmstate output is '--- {}\n'~~ OCPBUGS-4465: Log message if nmstate output is '--- {}\n' Dec 5, 2022

openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Dec 5, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 5, 2022

dtantsur reviewed Dec 5, 2022

View reviewed changes

openshift-ci bot requested a review from pamoedom December 5, 2022 14:01

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2023

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2023

Log message if nmstate output is '--- {}\n'

373fe33

k37y force-pushed the ocpbugs-4465 branch from 8213cbe to 373fe33 Compare May 2, 2023 14:24

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023

openshift-ci bot assigned elfosardo May 5, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2023

openshift-merge-robot merged commit 40c9f14 into openshift:main May 5, 2023

OCPBUGS-4465: Log message if nmstate output is '--- {}\n' #72

OCPBUGS-4465: Log message if nmstate output is '--- {}\n' #72

Uh oh!

Conversation

k37y commented Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 5, 2022

Uh oh!

openshift-ci-robot commented Dec 5, 2022

Uh oh!

openshift-ci-robot commented Dec 5, 2022

Uh oh!

openshift-ci-robot commented Dec 5, 2022

Uh oh!

openshift-ci-robot commented Dec 5, 2022

Uh oh!

openshift-ci-robot commented Dec 5, 2022

Uh oh!

openshift-ci-robot commented Dec 5, 2022

Uh oh!

openshift-ci-robot commented Dec 5, 2022

Uh oh!

dtantsur Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

k37y Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

dtantsur Mar 8, 2023

Choose a reason for hiding this comment

Uh oh!

k37y May 2, 2023

Choose a reason for hiding this comment

Uh oh!

dtantsur Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

k37y Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

dtantsur commented Dec 5, 2022

Uh oh!

openshift-ci-robot commented Dec 5, 2022

Uh oh!

openshift-bot commented Mar 6, 2023

Uh oh!

k37y commented Mar 6, 2023

Uh oh!

openshift-ci bot commented May 2, 2023

Uh oh!

dtantsur commented May 3, 2023

Uh oh!

openshift-ci bot commented May 3, 2023

Uh oh!

elfosardo commented May 5, 2023

Uh oh!

openshift-ci-robot commented May 5, 2023

Uh oh!

Uh oh!

k37y commented Dec 5, 2022 •

edited

Loading