Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws/vpc: add CRI-O metrics sg #1201

Merged
merged 1 commit into from
Feb 7, 2019
Merged

aws/vpc: add CRI-O metrics sg #1201

merged 1 commit into from
Feb 7, 2019

Conversation

runcom
Copy link
Member

@runcom runcom commented Feb 6, 2019

Ref: openshift/cluster-monitoring-operator#228

We need this to be able to scrape metrics from the worker prometheus is on

/cc @smarterclayton @brancz @mrunalp

Signed-off-by: Antonio Murdaca runcom@linux.com

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 6, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2019 •
edited

@runcom: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 5b55fa8 link /test e2e-openstack
ci/prow/e2e-libvirt 5b55fa8 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@runcom
aws/vpc: add CRI-O metrics sg-worker
dd413b6 
Signed-off-by: Antonio Murdaca <runcom@linux.com>
wking
wking approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2019
@openshift-merge-robot openshift-merge-robot merged commit 08afe7e into openshift:master Feb 7, 2019
@runcom runcom deleted the crio-metrics-sg branch February 7, 2019 14:36
@runcom runcom mentioned this pull request Feb 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking approved these changes

@brancz brancz Awaiting requested review from brancz

@mrunalp mrunalp Awaiting requested review from mrunalp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@runcom @openshift-ci-robot @wking @smarterclayton @brancz @openshift-merge-robot