Apply latest changes from metal3-io #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to configure the containers based on interface rather than specific IPs. We don't know the IP address the pod will be run on so we need a way to do this dynamically.
Add more configuration options to containers.
Publish ironic endpoint via mDNS
Apparently, iptables are not installed by default. This is hidden by the fact that the script doesn't fail on errors. And it hides the fact the the mdns iptables commands are not correct.
Install iptables explicitly and correct the iptables lines
There may be security vulnarabilities in the pre-installed packages, let's make sure we always have the latest versions.
openshift-ci-robot
added
the
size/M
juliakreger
reviewed
Jun 11, 2019
runironic.sh
Outdated
| @@ -66,7 +75,7 @@ rm -rf /shared/log/ironic | |||
| mkdir -p /shared/log/ironic | |||
|
|
|||
| /usr/bin/python2 /usr/bin/ironic-conductor --log-file /shared/log/ironic/ironic-conductor.log & | |||
| /usr/bin/python2 /usr/bin/ironic-api --log-file /shared/log/ironic/ironic-api.log & | |||
| /usr/bin/python2 /usr/bin/ironic-api --log-file /shared/log/ironic/ironic-api.log & | |||
There was a problem hiding this comment.
Python2, We need to fix this upstream.
juliakreger
approved these changes
Jun 11, 2019
Do not use hard coded Python 2
Update all packages when building an image
After metal3-io/ironic-inspector-image#25 these parameters are distributed via mDNS. Duplicating them here is confusing, since this image is supposed to be for ironic.
Stop defining inspection kernel params in ironic-image
We want to stop running several processes in one container, since it violates container good practices and makes collecting logs and health checking much harder.
Allow running ironic API, conductor and exporter separately
openshift-ci-robot
added
size/L
dtantsur
approved these changes
Jul 8, 2019
This commit changes the ironic-image to use the ironic-prometheus-exporter Package that is now available in RDO. - Updated Dockerfile - Removed installexporter.sh - Updated runexporterapp.sh
Repair logging of ironic-services to /shared/log
Start using ironic-prometheus-exporter package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.