Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with metal3-io/main #259

Merged
merged 13 commits into from Mar 11, 2022

Conversation

elfosardo
Copy link

No description provided.

dtantsur and others added 13 commits February 14, 2022 14:25
Got reintroduced by mistake in 39c5b7d.
glibc-gconv-extra was included by default in the past and
we need it otherwise mkfs.msdos will fail with:
``Cannot initialize conversion from codepage 850 to ANSI_X3.4-1968: Invalid argument``
``Cannot initialize conversion from ANSI_X3.4-1968 to codepage 850: Invalid argument``
subsequently making mmd fail with:
``Error converting to codepage 850 Invalid argument``
``Cannot initialize '::'``
This is due to the conversion table missing codepage 850, included
in glibc-gconv-extra
Remove unused dependencies - take 2
Iury is the Ironic PTL (project team lead) and has been consistently
reviewing ironic-image changes in his reviewer role.

Stephen has moved to another role.
Fix missing codepage 850 in conversion table
Promote Iury to approvers, remove Stephen
There seems to be an issue where ipmitool does not retry with different
ciphers. This could be worked around by letting Ironic handle the retry
instead.
…stead-of-ipmitool

Let Ironic handle retry instead of ipmitool
Also moved the version to an ARG
Clean packages after install and added some env vars to sushy-tools container
@elfosardo elfosardo changed the title Sync m3 main 220311 Sync with metal3-io/main Mar 11, 2022
@openshift-ci openshift-ci bot requested review from bfournie and zaneb March 11, 2022 09:34
@openshift-ci
Copy link

openshift-ci bot commented Mar 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2022
@elfosardo
Copy link
Author

/cc @iurygregory @dtantsur

@dtantsur
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2022
@openshift-merge-robot openshift-merge-robot merged commit e881b14 into openshift:master Mar 11, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 11, 2022

@elfosardo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

joepvd pushed a commit to joepvd/ironic-image that referenced this pull request Apr 11, 2022
Fix the issue that the OS is not a Stream version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants