Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.13] OCPBUGS-40929: update VPA golang.org/x/net for http rapid reset for CVE-2024-8421 #317

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

joelsmith
Copy link

go get golang.org/x/net@v0.23.0
go mod tidy
go mod vendor

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2024
@openshift-ci-robot
Copy link

@joelsmith: This pull request references Jira Issue OCPBUGS-40929, which is invalid:

  • expected dependent Jira Issue OCPBUGS-40925 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

go get golang.org/x/net@v0.23.0
go mod tidy
go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 9, 2024
@openshift-ci openshift-ci bot requested review from damdo and RadekManak September 9, 2024 21:19
@joelsmith joelsmith changed the title OCPBUGS-40929: update VPA golang.org/x/net for http rapid reset for CVE-2024-8421 [release-4.13] OCPBUGS-40929: update VPA golang.org/x/net for http rapid reset for CVE-2024-8421 Sep 10, 2024
@joelsmith
Copy link
Author

I have no idea if the failing tests are expected to pass on this branch. We might need to flag/skip them.

/retest

@joelsmith
Copy link
Author

/retest

@asahay19
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 10, 2024
Copy link

openshift-ci bot commented Sep 10, 2024

@joelsmith: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-operator 3d1c67a link false /test e2e-azure-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@joelsmith
Copy link
Author

/retest-required

@jkyros
Copy link

jkyros commented Sep 12, 2024

That first e2e-azure-operator run went fine-ish until it failed on that cluster autoscaler test, it looks like it didn't even make it to the vpa tests.

   [TIMEDOUT] Managed cluster should when machineset has one replica [It] have ability to additively reconcile taints from machine to nodes [machines]
  /go/src/github.com/openshift/cluster-api-actuator-pkg/pkg/infra/infra.go:195

The other two look like it's the installer having problem with the install config and some azure user tag feature gates:

 baseDomain: ci.azure.devcluster.openshift.com
platform:
  azure:
    region: centralus
    userTags:
      expirationDate: 2024-09-10T13:35+00:00
    baseDomainResourceGroupName: os4-common
controlPlane:
  architecture: amd64
  name: master
  platform:
    azure:
      type: null
compute:
- architecture: amd64
  name: worker
  replicas: 3
  platform:
    azure:
      type: Standard_D4s_v3
level=error msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: platform.azure.userTags: Forbidden: the TechPreviewNoUpgrade feature set must be enabled to use this field
Create manifests exit code: 3

I don't think we can really affect that either. And we didn't bump any Azure deps or anything so I'm reasonably sure we didn't specifically break Azure. (Plus the Azure test is not required)

Thanks for cranking through these Joel!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
@joelsmith
Copy link
Author

/approve
/label backport-risk-assessed
/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 16, 2024
@openshift-ci-robot
Copy link

@joelsmith: This pull request references Jira Issue OCPBUGS-40929, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-40925 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-40925 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/approve
/label backport-risk-assessed
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 16, 2024
Copy link

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c38cc4e into openshift:release-4.13 Sep 16, 2024
11 of 12 checks passed
@openshift-ci-robot
Copy link

@joelsmith: Jira Issue OCPBUGS-40929: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-40929 has been moved to the MODIFIED state.

In response to this:

go get golang.org/x/net@v0.23.0
go mod tidy
go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: vertical-pod-autoscaler
This PR has been included in build ose-vertical-pod-autoscaler-container-v4.13.0-202409161537.p0.gc38cc4e.assembly.stream.el8.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: atomic-openshift-cluster-autoscaler
This PR has been included in build atomic-openshift-cluster-autoscaler-container-v4.13.0-202409161537.p0.gc38cc4e.assembly.stream.el8.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.13.0-0.nightly-2024-09-16-192737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.