Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12] OCPBUGS-40928: update VPA golang.org/x/net for http rapid reset for CVE-2024-8421 #318

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

joelsmith
Copy link

go get golang.org/x/net@v0.23.0
go mod tidy
go mod vendor

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2024
@openshift-ci-robot
Copy link

@joelsmith: This pull request references Jira Issue OCPBUGS-40928, which is invalid:

  • expected dependent Jira Issue OCPBUGS-40929 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

go get golang.org/x/net@v0.23.0
go mod tidy
go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 9, 2024
@openshift-ci openshift-ci bot requested review from elmiko and frobware September 9, 2024 21:22
@joelsmith joelsmith changed the title OCPBUGS-40928: update VPA golang.org/x/net for http rapid reset for CVE-2024-8421 [release-4.12] OCPBUGS-40928: update VPA golang.org/x/net for http rapid reset for CVE-2024-8421 Sep 10, 2024
@joelsmith
Copy link
Author

I have no idea if the failing tests are expected to pass on this branch. We might need to flag/skip them.

/retest

@joelsmith
Copy link
Author

/retest

@asahay19
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 10, 2024
Copy link

openshift-ci bot commented Sep 10, 2024

@joelsmith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift 8e8fc8a link false /test e2e-hypershift
ci/prow/e2e-azure-operator 8e8fc8a link false /test e2e-azure-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@joelsmith
Copy link
Author

/retest-required

@jkyros
Copy link

jkyros commented Sep 13, 2024

Azure tests looks about like it did for 4.13, only it doesn't understand userTags at all (presumably since we're back a version).

level=warning msg=failed to parse first occurence of unknown field: failed to unmarshal install-config.yaml: error unmarshaling JSON: while decoding JSON: json: unknown field "userTags"
level=info msg=Attempting to unmarshal while ignoring unknown keys because strict unmarshaling failed

Hypershift...looks like it never gets the nodes it wants for TestCreateClusterPrivate . I looked at the test https://github.com/openshift/hypershift/blob/da93f69c5c56fe938e65115dd08428604ed42bed/test/e2e/create_cluster_test.go#L145 but nothing stood out.

Neither of them are required and I think it's very unlikely we broke it.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2024
@joelsmith
Copy link
Author

/jira refresh
/approve
/label backport-risk-assessed

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 18, 2024
@openshift-ci-robot
Copy link

@joelsmith: This pull request references Jira Issue OCPBUGS-40928, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-40929 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-40929 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh
/approve
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 18, 2024
Copy link

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f4975ee into openshift:release-4.12 Sep 18, 2024
10 of 12 checks passed
@openshift-ci-robot
Copy link

@joelsmith: Jira Issue OCPBUGS-40928: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-40928 has been moved to the MODIFIED state.

In response to this:

go get golang.org/x/net@v0.23.0
go mod tidy
go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: atomic-openshift-cluster-autoscaler
This PR has been included in build atomic-openshift-cluster-autoscaler-container-v4.12.0-202409181500.p0.gf4975ee.assembly.stream.el8.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: vertical-pod-autoscaler
This PR has been included in build ose-vertical-pod-autoscaler-container-v4.12.0-202409181500.p0.gf4975ee.assembly.stream.el8.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants