Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rebase 1.25 #1357

Closed
wants to merge 2,298 commits into from
Closed

WIP: Rebase 1.25 #1357

wants to merge 2,298 commits into from

Conversation

rphillips
Copy link

No description provided.

k8s-ci-robot and others added 30 commits August 2, 2022 11:38
…sruption

Add worker to clean up stale DisruptionTarget condition
…-test

Promote NamespaceStatus endpoints test +3 Endpoints
…a2-deprecated

Deprecate kubescheduler ComponentConfig v1beta2
ginkgo: disable color escape sequences by default when not connected to a terminal
KEP-3327: Add CPUManager policy option to align CPUs by Socket instead of by NUMA node
Upgrade CSIMigrationGCE feature gate to GA
Enable 'running_managed_controllers' for KCM/CCM controllers: routes, services and cloud-node
…nges

Update CRI API to support Evented PLEG
…ges for kubelet client and serving certificates

Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
It is used to request that a pod runs in a unique user namespace.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
Co-authored-by: Rodrigo Campos <rodrigoca@microsoft.com>
Move e2e test from alpha with feature promoted to beta
…ment

Allow retroactive storage class assigment to PVCs
KEP: /enhancements/keps/sig-node/1287-in-place-update-pod-resources
Change-Id: I3be351fb3b53216948a37b1d58224f8fbbf22b47
…uceeded

Fix JobTrackingWithFinalizers when a pod succeeds after the job fails
…ional

modify the signing/approving controller to tolerate either set of usages for kubelet client and serving certificates
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
rphillips and others added 22 commits August 22, 2022 18:13
openshift-rebase(v1.24):source=4ac30cd9474
…ure File

This commit is the next natural step for commits 2d9a8f9
and d37e84c. It introduces custom feature gates to enable
the CSI migration in vSphere and Azure File plugins.

See openshift/enhancements#549 for details.

Stop <carrying> the patch when CSI migration becomes GA (i.e.
features.CSIMigrationAzureFile / features.CSIMigrationVSphere
are GA).

openshift-rebase(v1.24):source=2701d71abb4
…time to unmount

UPSTREAM: <carry>: Fix sync of PV deletion in PV controller

Always queue PV deletion events immediately, without any wait. It does not
affect dynamic de-provisioning / deletion of volumes, it's done on PVC
deletion.

This de-flakes unit tests, which expect that PV deletion is processed without
waiting too much.

This updates carry patch b24f93e. It still waits for 21 seconds after *PVC*
deletion!
UPSTREAM: <carry>: delay queuing deletion for PV to allow nodes some time to unmount

openshift-rebase(v1.24):source=c5fd3449734
…etup

openshift-rebase(v1.24):source=ce8d63d76a0
…tioning is disabled

Signed-off-by: Artyom Lukianov <alukiano@redhat.com>

openshift-rebase(v1.24):source=aa8752060b0
…d to CSI

Skip test that depend on in-tree Azure Disk volume plugin that (wrongly)
uses failure domains for value of "topology.kubernetes.io/zone" label in
Azure regions that don't have availability zones.

Our e2e tests blindly use that label and expect that a volume provisioned
in such a "zone" can be used only by nodes in that "zone" (= topology
domain). This is false, Azure Disk CSI driver can use such a volume in any
zone and therefore the test may randomly fail.

See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2066865

openshift-rebase(v1.24):source=7871e95298a
In the tests, we oftentimes create pods directly by the administrative
user and so their SCC-related privileges are being used to create the
pods. The PSa label syncher however works by introspecting SAs in each
namespace, and since the SAs in the direct pod creation use-cases don't
have the SCC-related privileges, the labelsyncer evaluates these
namespaces as "restricted" because only the "restricted-v2" SCC is ever
assigned in the namespaces. This breaks tests where pods are created
directly.

openshift-rebase(v1.24):source=35dc012e1f5
Remove reserved CPUs from default set when workload partitioning is
enabled.

Co-Authored-By: Brent Rowsell <browsell@redhat.com>
Signed-off-by: Don Penney <dpenney@redhat.com>
…aren't causing problems when auto-attached by ginkgo
when we run verify-import-boss.sh it fails with the following error

errors in package "k8s.io/kubernetes/cmd/kubeadm/app/phases/bootstraptoken/node":
the following imports did not match any allowed prefix:
  gopkg.in/yaml.v3
  k8s.io/kube-openapi/pkg/validation/spec

note: this should be an upstream fix, not sure why we don't see this
error in upstream, does upstream not run this job in verify?
investigate and take proper action for this commit
…space

The main purpose of this change is to update the e2e Netpol tests to use
the srandard CreateNamespace function from the Framework. Before this
change, a custom Namespace creation function was used, with the
following consequences:

* Pod security admission settings had to be enforced locally (not using
  the centralized mechanism)
* the custom function was brittle, not waiting for default Namespace
  ServiceAccount creation, causing tests to fail in some infrastructures
* tests were not benefiting from standard framework capabilities:
  Namespace name generation, automatic Namespace deletion, etc.

As part of this change, we also do the following:

* clearly decouple responsibilities between the Model, which defines the
  K8s objects to be created, and the KubeManager, which has access to
  runtime information (actual Namespace names after their creation by
  the framework, Service IPs, etc.)
* simplify / clean-up tests and remove as much unneeded logic / funtions
  as possible for easier long-term maintenance
* remove the useFixedNamespaces compile-time constant switch, which
  aimed at re-using existing K8s resources across test cases. The
  reasons: a) it is currently broken as setting it to true causes most
  tests to panic on the master branch, b) it is not a good idea to have
  some switch like this which changes the behavior of the tests and is
  never exercised in CI, c) it cannot possibly work as different test
  cases have different Model requirements (e.g., the protocols list can
  differ) and hence different K8s resource requirements.

For kubernetes#108298

Signed-off-by: Antonin Bas <abas@vmware.com>
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 26, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2022
@openshift-ci-robot
Copy link

@rphillips: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from deads2k and sttts August 26, 2022 20:38
@openshift-ci
Copy link

openshift-ci bot commented Aug 26, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rphillips
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval by writing /assign @deads2k in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Aug 27, 2022

@rphillips: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade 97b8938 link false /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade
ci/prow/k8s-e2e-gcp 97b8938 link true /test k8s-e2e-gcp
ci/prow/k8s-e2e-gcp-serial 97b8938 link true /test k8s-e2e-gcp-serial
ci/prow/e2e-gcp 97b8938 link true /test e2e-gcp
ci/prow/e2e-gcp-upgrade 97b8938 link true /test e2e-gcp-upgrade
ci/prow/k8s-e2e-conformance-aws 97b8938 link true /test k8s-e2e-conformance-aws
ci/prow/verify-commits 97b8938 link true /test verify-commits
ci/prow/e2e-aws-serial 97b8938 link true /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rphillips rphillips closed this Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet