Skip to content

Conversation

tchap
Copy link
Contributor

@tchap tchap commented Sep 11, 2025

The updated version contains Client.Unbind method that is needed.

To make the update work, had to align a fake LDAP client, or rather extend it with new methods.

Required by openshift/oc#2094

@openshift-ci-robot
Copy link

@tchap: This pull request explicitly references no jira issue.

In response to this:

The updated version contains Client.Unbind method that is needed.

To make the update work, had to align a fake LDAP client, or rather extend it with new methods.

Required by openshift/oc#2094

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2025
@openshift-ci openshift-ci bot requested review from deads2k and ibihim September 11, 2025 06:29
Copy link
Contributor

@p0lyn0mial p0lyn0mial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually keep vendor changes in a separate commit.
it is just easier to review as we don't have to review changes to the vendor dir.

please split the commit into two, one with the vendor changes and the other one with changes to the lib-go

@tchap tchap force-pushed the vendor-update-ldap branch from 84b4e30 to 77cdb9d Compare September 11, 2025 07:25
@p0lyn0mial
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2025
Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2025
Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

@tchap: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e2c18d5 into openshift:master Sep 11, 2025
4 checks passed
@tchap tchap deleted the vendor-update-ldap branch September 11, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants