OCPBUGS-60037: Allow duplicate options in ptpconfig

[josephdrichard]

Cherry-pick of change to allow duplicate keys in section of ptpconfig.

When initially designing PTP config parsing, there was an assumption
that for each section, all of the keys were unique. Based on this
assumption, key:value pairs for a given section were stored as a
map[string][string].

With the introduction of unicast_master_table, this assumption is no
longer true, as in the case of the UDPv4 key, there can be multiple
entries with the same key. As such, the config data structure is
changed to maintain a list of individual key:value pairs, rather than a
map of keys to values.

In addition, some restructuring was done for places that relied on the
pre-existing structure, moving most of that functionality to utility
functions in config.go

Also removes considering masterOnly 0 under [global] section when determining clock type

[openshift-ci-robot]

@josephdrichard: This pull request references Jira Issue OCPBUGS-59160, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• expected dependent Jira Issue OCPBUGS-55732 to target a version in 4.19.0, 4.19.z, but it targets "4.20.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Cherry-pick of change to allow duplicate keys in section of ptpconfig.

When initially designing PTP config parsing, there was an assumption
that for each section, all of the keys were unique. Based on this
assumption, key:value pairs for a given section were stored as a
map[string][string].

With the introduction of unicast_master_table, this assumption is no
longer true, as in the case of the UDPv4 key, there can be multiple
entries with the same key. As such, the config data structure is
changed to maintain a list of individual key:value pairs, rather than a
map of keys to values.

In addition, some restructuring was done for places that relied on the
pre-existing structure, moving most of that functionality to utility
functions in config.go

Also removes considering masterOnly 0 under [global] section when determining clock type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[josephdrichard]

/jira cherrypick OCPBUGS-59160

[openshift-ci-robot]

@josephdrichard: Jira Issue OCPBUGS-59160 has been cloned as Jira Issue OCPBUGS-60037. Will retitle bug to link to clone.
/retitle OCPBUGS-60037: OCPBUGS-59160: Allow duplicate options in ptpconfig

In response to this:

/jira cherrypick OCPBUGS-59160

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@josephdrichard: This pull request references Jira Issue OCPBUGS-60037, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.z) matches configured target version for branch (4.18.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-59160 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-59160 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
• bug has dependents

Requesting review from QA contact:
/cc @yliu127

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Cherry-pick of change to allow duplicate keys in section of ptpconfig.

When initially designing PTP config parsing, there was an assumption
that for each section, all of the keys were unique. Based on this
assumption, key:value pairs for a given section were stored as a
map[string][string].

With the introduction of unicast_master_table, this assumption is no
longer true, as in the case of the UDPv4 key, there can be multiple
entries with the same key. As such, the config data structure is
changed to maintain a list of individual key:value pairs, rather than a
map of keys to values.

In addition, some restructuring was done for places that relied on the
pre-existing structure, moving most of that functionality to utility
functions in config.go

Also removes considering masterOnly 0 under [global] section when determining clock type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[aneeshkp]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, josephdrichard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aneeshkp,josephdrichard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[josephdrichard]

/retest

[aneeshkp]

/label backport-risk-assessed

[openshift-ci]

@josephdrichard: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@josephdrichard: Jira Issue OCPBUGS-60037: All pull requests linked via external trackers have merged:

• openshift/linuxptp-daemon#474

Jira Issue OCPBUGS-60037 has been moved to the MODIFIED state.

In response to this:

Cherry-pick of change to allow duplicate keys in section of ptpconfig.

When initially designing PTP config parsing, there was an assumption
that for each section, all of the keys were unique. Based on this
assumption, key:value pairs for a given section were stored as a
map[string][string].

With the introduction of unicast_master_table, this assumption is no
longer true, as in the case of the UDPv4 key, there can be multiple
entries with the same key. As such, the config data structure is
changed to maintain a list of individual key:value pairs, rather than a
map of keys to values.

In addition, some restructuring was done for places that relied on the
pre-existing structure, moving most of that functionality to utility
functions in config.go

Also removes considering masterOnly 0 under [global] section when determining clock type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[josephdrichard]

/cherrypick release-4.17

[openshift-cherrypick-robot]

@josephdrichard: new pull request created: #478

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: linuxptp-daemon
This PR has been included in build ose-linuxptp-daemon-container-v4.18.0-202508062303.p0.ge8ce938.assembly.stream.el9.
All builds following this will include this PR.