OCPCLOUD-1769: Make machine phases public consts

[cjschaef]

Rather than forcing machine providers to replicate the machine phases, if needed, the phases should be made public consts instead.

Related: https://issues.redhat.com/browse/OCPCLOUD-1769

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval by writing /assign @enxebre in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cjschaef]

/hold

[cjschaef]

Resolved the main issue of missing most variable renames.
/unhold

[openshift-ci]

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-sdn	3850b59	link	false	/test e2e-metal-ipi-sdn
ci/prow/e2e-openstack	3850b59	link	false	/test e2e-openstack
ci/prow/e2e-vsphere-operator	3850b59	link	false	/test e2e-vsphere-operator
ci/prow/e2e-vsphere-ovn-upgrade	3850b59	link	false	/test e2e-vsphere-ovn-upgrade
ci/prow/e2e-vsphere-ovn	3850b59	link	false	/test e2e-vsphere-ovn
ci/prow/e2e-azure-ovn	3850b59	link	false	/test e2e-azure-ovn
ci/prow/e2e-libvirt	3850b59	link	false	/test e2e-libvirt
ci/prow/e2e-metal-ipi-upgrade	3850b59	link	false	/test e2e-metal-ipi-upgrade
ci/prow/e2e-nutanix	3850b59	link	false	/test e2e-nutanix

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[JoelSpeed]

I had imagined we would move these consts to the API repo and have folks import them from there, ie machinev1beta1.PhaseFailed, I guess since every MAPI implementation imports this package already this also works

[JoelSpeed]

/retest-required

[lobziik]

+1 to what @JoelSpeed said. I would prefer to have this within the API definitions.

[cjschaef]

Okay, I didn't realize that was the expectation. I can update the Jira, to make changes to API, and I'd expect it would be best to pull those changes back into MAO once they are available, along with updates to the providers as well (for now, I am only aware of IBM Cloud MAPI).

I'll close this PR out then, and open a follow up PR once the changes to API get updated.