Skip to content

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Dec 12, 2024

SPLAT-1940

Changes

  • Enhanced vsphere modules to use FeatureGate mutable map for passing around feature gates instead of using each individual feature gate as a boolean.
  • Added static ip CRDs for tests. Due to CRD not being pullable from github due to no .go files, these were added to third_party for this purpose.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 12, 2024

@vr4manta: This pull request references SPLAT-1940 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

SPLAT-1940

Changes

  • Enhanced vsphere modules to use FeatureGate mutable map for passing around feature gates instead of using each individual feature gate as a boolean.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 12, 2024
@openshift-ci openshift-ci bot requested review from elmiko and JoelSpeed December 12, 2024 18:57
@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 12, 2024

@vr4manta: This pull request references SPLAT-1940 which is a valid jira issue.

In response to this:

SPLAT-1940

Changes

  • Enhanced vsphere modules to use FeatureGate mutable map for passing around feature gates instead of using each individual feature gate as a boolean.
  • Added static ip CRDs for tests. Due to CRD not being pullable from github due to no .go files, these were added to third_party for this purpose.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@vr4manta
Copy link
Contributor Author

/assign @JoelSpeed

Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 281f7d4 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 63a4f18 into openshift:master Dec 13, 2024
28 of 29 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-api-operator
This PR has been included in build ose-machine-api-operator-container-v4.19.0-202412131335.p0.g63a4f18.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants