Skip to content

OCPBUGS-49413: add image/read permissions #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

OCPBUGS-49413: add image/read permissions #1330

merged 1 commit into from
Feb 19, 2025

Conversation

miyadav
Copy link
Member

@miyadav miyadav commented Feb 7, 2025

This is to resolve the permission issue when upgraded from 4.11 -> 4.14 .

more context on it here

PTAL when time permits.

@openshift-ci openshift-ci bot requested review from damdo and RadekManak February 7, 2025 10:34
@miyadav
Copy link
Member Author

miyadav commented Feb 7, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@miyadav: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@miyadav miyadav changed the title OCPBUGS-49413 - add image/read permissions OCPBUGS-49413 :add image/read permissions Feb 7, 2025
@miyadav
Copy link
Member Author

miyadav commented Feb 7, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@miyadav: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@miyadav miyadav changed the title OCPBUGS-49413 :add image/read permissions OCPBUGS-49413: add image/read permissions Feb 7, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 7, 2025
@openshift-ci-robot
Copy link
Contributor

@miyadav: This pull request references Jira Issue OCPBUGS-49413, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is to resolve the permission issue when upgraded from 4.11 -> 4.14 .

more context on it here

PTAL when time permits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025 •
edited
Loading

@miyadav: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-virtualmedia c21bdf2 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-vsphere-operator c21bdf2 link false /test e2e-vsphere-operator
ci/prow/e2e-vsphere-ovn-multi-vcenter c21bdf2 link false /test e2e-vsphere-ovn-multi-vcenter
ci/prow/e2e-vsphere-ovn c21bdf2 link false /test e2e-vsphere-ovn
ci/prow/e2e-nutanix c21bdf2 link false /test e2e-nutanix
ci/prow/e2e-vsphere-ovn-upgrade c21bdf2 link false /test e2e-vsphere-ovn-upgrade
ci/prow/e2e-vsphere-ovn-serial c21bdf2 link false /test e2e-vsphere-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@miyadav
Copy link
Member Author

miyadav commented Feb 10, 2025

@damdo PTAL when time permits.

@damdo
Copy link
Member

damdo commented Feb 13, 2025

@miyadav this was already QE tested right?

@damdo
Copy link
Member

damdo commented Feb 13, 2025

/retest-required

@damdo
Copy link
Member

damdo commented Feb 13, 2025

@miyadav sounds like you need to update the target version on the bug to "4.19.0"

@miyadav
Copy link
Member Author

miyadav commented Feb 13, 2025

@miyadav this was already QE tested right?

yes @damdo .

damdo
damdo reviewed Feb 13, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @miyadav
As such

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
@damdo
Copy link
Member

damdo commented Feb 13, 2025

/test e2e-azure-ovn

@damdo
Copy link
Member

damdo commented Feb 19, 2025

/label acknowledge-critical-fixes-only

This was thoroughly tested by QE members of our team and it is a relaxation of permissions, which we consider safe.

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 19, 2025
@JoelSpeed
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 19, 2025
@openshift-ci-robot
Copy link
Contributor

@JoelSpeed: This pull request references Jira Issue OCPBUGS-49413, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 19, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: miyadav.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@JoelSpeed: This pull request references Jira Issue OCPBUGS-49413, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f86d206 into openshift:master Feb 19, 2025
22 of 29 checks passed
@openshift-ci-robot
Copy link
Contributor

@miyadav: Jira Issue OCPBUGS-49413: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-49413 has been moved to the MODIFIED state.

In response to this:

This is to resolve the permission issue when upgraded from 4.11 -> 4.14 .

more context on it here

PTAL when time permits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-api-operator
This PR has been included in build ose-machine-api-operator-container-v4.19.0-202502191708.p0.gf86d206.assembly.stream.el9.
All builds following this will include this PR.

@miyadav
Copy link
Member Author

miyadav commented Mar 7, 2025

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link

@miyadav: new pull request created: #1342

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@RadekManak RadekManak Awaiting requested review from RadekManak

Assignees

@damdo damdo

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miyadav @openshift-ci-robot @damdo @JoelSpeed @openshift-bot @openshift-cherrypick-robot