Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.3] Bug 1851949: Set the pod-infra-container-image flag in kubelet to ocp pause image #1877

Merged
merged 1 commit into from
Jul 2, 2020
Merged

[release-4.3] Bug 1851949: Set the pod-infra-container-image flag in kubelet to ocp pause image #1877

merged 1 commit into from
Jul 2, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1838

/assign umohnani8

@umohnani8
Set the pod-infra-container-image flag in kubelet to ocp pause image
4ca5f0d 
By default, kubelet sets the pod-infra-container-image flag to k8s.gcr.io/pause:3.1.
The kubelet does an image status call for this image every few minutes and that is
why we were seeing the warning logs in cri-o saying this pause image is not found.
Overriding the pod-infra-container-image flag here to ensure the image status calls
we get from the kubelet is for the ocp pause image.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 29, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1848021 has been cloned as Bugzilla bug 1851949. Retitling PR to link against new bug.
/retitle [release-4.3] [release-4.4] Bug 1851949: Set the pod-infra-container-image flag in kubelet to ocp pause image

In response to this:

[release-4.3] [release-4.4] Bug 1848021: Set the pod-infra-container-image flag in kubelet to ocp pause image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] [release-4.4] Bug 1848021: Set the pod-infra-container-image flag in kubelet to ocp pause image [release-4.3] [release-4.4] Bug 1851949: Set the pod-infra-container-image flag in kubelet to ocp pause image Jun 29, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 29, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1851949, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1848021 is in the state RELEASE_PENDING, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1848021 targets the "4.4.z" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • bug has dependents

In response to this:

[release-4.3] [release-4.4] Bug 1851949: Set the pod-infra-container-image flag in kubelet to ocp pause image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umohnani8
Copy link
Contributor

@kikisdeliveryservice PTAL
I don't have permissions to fix the PR title :/

@kikisdeliveryservice kikisdeliveryservice changed the title [release-4.3] [release-4.4] Bug 1851949: Set the pod-infra-container-image flag in kubelet to ocp pause image [release-4.3] Bug 1851949: Set the pod-infra-container-image flag in kubelet to ocp pause image Jun 29, 2020
@kikisdeliveryservice
Copy link
Contributor

@kikisdeliveryservice PTAL
I don't have permissions to fix the PR title :/

done :)

@kikisdeliveryservice
Copy link
Contributor

/retest

@kikisdeliveryservice
Copy link
Contributor

/skip

kikisdeliveryservice
kikisdeliveryservice approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020
@runcom
Copy link
Member

runcom commented Jun 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, openshift-cherrypick-robot, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 2, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 2, 2020 •
edited
Loading

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 4ca5f0d link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jul 2, 2020
Merged
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 738d844 into openshift:release-4.3 Jul 2, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1877, openshift/installer#3815. Bugzilla bug 1851949 has been moved to the MODIFIED state.

In response to this:

[release-4.3] Bug 1851949: Set the pod-infra-container-image flag in kubelet to ocp pause image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@cgwalters cgwalters Awaiting requested review from cgwalters

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

Assignees

@runcom runcom

@umohnani8 umohnani8

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @umohnani8 @kikisdeliveryservice @runcom @openshift-bot @sdodson @openshift-merge-robot