Sync with upstream 06-09-2022 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
pperiyasamy
changed the title
|
/retest |
pperiyasamy
force-pushed
the
sync_17-08-2022
branch
2 times, most recently
from
65e2566
to
8371635
Compare
openshift-merge-robot
added
the
needs-rebase
pperiyasamy
force-pushed
the
sync_17-08-2022
branch
from
8371635
to
718e464
Compare
openshift-merge-robot
removed
the
needs-rebase
pperiyasamy
changed the title
|
/retest |
pperiyasamy
force-pushed
the
sync_17-08-2022
branch
from
6d03662
to
12ab4fb
Compare
openshift-merge-robot
added
the
needs-rebase
Fixing the broken links to relative configuration sections. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
We need to have a valid format and not only the placeholder, as the apiserver will refuse deletion with "unable to load root certificates: unable to parse bytes as PEM block"
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
More for consistency rather than real need, as the namespace gets overridden when applying kustomize. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Adding a mention to metallb#1437 Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Adding more details on how to use the secret field of bgppeer to use a secret as password. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Regenerate the docs to align. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Regenerating the manifests. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
The current replacement rules work only for main (and the frr one is even bugged). Fixing to work also when moving from a minor version to the next one. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Error during translating from configmaps, the right name is autoAssign. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
No need for raw, need to point to the repo. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
Currently, there's nothing preventing the CRs to be created in a namespace different from the one metallb is deployed to. This change adds namespace validation to prevent creation of CRs in a different namespace.
For each CR, we try creating a resource in a namespace other than the metallb namespace and expect a failure.
Add a mention to metallb#1523
Deploying prometheus to be able to run prometheus tests. Also, add lanes with no prometheus. We want to make sure the deployment works also with no prometheus, so add a few helm / manifest lanes without it. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Extending the docs accordingly. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
The prometheus tests add test duration time. Raising the timeout to accomodate them. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
pperiyasamy
force-pushed
the
sync_17-08-2022
branch
from
12ab4fb
to
3d03756
Compare
openshift-merge-robot
removed
the
needs-rebase
fedepaol
reviewed
Sep 7, 2022
openshift-ci/run_e2e.sh
Outdated
| @@ -74,4 +74,4 @@ FOCUS="\"L2.*should work for ExternalTrafficPolicy=Cluster\"\|\"BGP.*A service o | |||
| inv e2etest --kubeconfig=$(readlink -f ../../../ocp/ostest/auth/kubeconfig) \ | |||
| --service-pod-port=8080 --system-namespaces="metallb-system" --skip-docker \ | |||
| --ipv4-service-range=192.168.10.0/24 --ipv6-service-range=fc00:f853:0ccd:e799::/124 \ | |||
| --focus="${FOCUS}" --use-operator | |||
| --prometheus-namespace="openshift-monitoring" --focus="${FOCUS}" | |||
There was a problem hiding this comment.
this needs to be left as it was, it's the backward compatiility tests
Now e2e tests are made to consume metrics directly from prometheus server pod for validation. so passing its namespace parameter so that pod lookup in e2e tests would succeed. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
Pod security policy is removed from 1.25, and 1.23 supports pod security admission, so we are definetely migrating away from psp. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com> (cherry picked from commit c65bdb8)
Psp is removed in 1.25, and from 1.23 pod security admission is officially supported, so we can safely remove psp. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com> (cherry picked from commit 85f3f0c)
Instead of deploying on the default namespace, we create the metallb-system namespace and deploy there. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com> (cherry picked from commit 464f930)
Now inv dev-env deploys on metallb-system with helm too, so we must instruct the tests about it. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com> (cherry picked from commit cbf7bf8)
When using servicemonitors, we must grant prometheus access to services and endpoints too. This wasn't failing CI because when deploying prometheus, it's granted permissions against the default namespace. It started to fail when we deployed metallb on a different ns. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com> (cherry picked from commit 8b28ef5)
In transitioning to dual stack we introduced an issue: if the ip was found, instead of returning the new code continued, grewing the a.ips[name] list on every service update. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com> (cherry picked from commit 249d681)
Extend the release notes with the 0.13.5 content. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com> (cherry picked from commit 1a06fbc)
This commit allows users to run configmaptocrs while mounting an existing configmap. Added `-only-data` flag, set to true if the input file is only the configMap data And: `-stdout` - set to true to write crs to stdout README was updated accordingly. fix metallb#1527 (cherry picked from commit db3f752)
Created two directories to test the generator with different source type: configmap yaml, and configmap data. Each directory includes a YAML for each resource type, and one with all of them. (cherry picked from commit ea5396d)
v1beta1 is not being served anymore in 1.25, which will make metallb unable to detect the availability of epslices. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com> (cherry picked from commit bd93630)
Here we add a test validating metallb works with a service with both udp and tcp associated. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com> (cherry picked from commit 91b34a0)
It might be useful to know how long an operation lasts for debugging purpouses. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com> (cherry picked from commit 0b8067a)
It normally takes 2-3 seconds to execute a full reload command. In case of multiple requests in flight, this translates in accumulated requests that end up in pending sighup requests that then translates into allocated memory (basically we have one child frr_reloader process per reload request, consuming memory). In case a service is constantly updated (for example, a dangling endpoint that makes the service available / not available too fast), we may end up accumulating memory that we are not able to free fast (because the number of requests is higher than how fast the reloader can serve them). Because of this, it's safer to accumulate the requests for at least how long it takes to serve one. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com> (cherry picked from commit 1de7f14)
In case the same configuration is propagated to the reloader, we ignore it instead of calling frr again. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com> (cherry picked from commit 8377501)
pperiyasamy
force-pushed
the
sync_17-08-2022
branch
from
3d03756
to
a606358
Compare
|
@pperiyasamy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fedepaol, pperiyasamy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.