Skip to content

Conversation

zhuje
Copy link
Contributor

@zhuje zhuje commented May 30, 2025

JIRA

https://issues.redhat.com/browse/OU-829

Description

This is a backport of fixes resolved in the main branch.

  • ACM Alerting filtering
  • Add 'Export as CSV'

Process

  • Copy/Paste Changes from main branch > AlertsPage, which has already fixed these issues for 4.19.
  • Adjust for Patternfly 5 (HTML is slightly different to accommodate Patternfly 5 instead of Patternfly 6). Business logic should be the same as main branch > AlertsPage (as of May 30).

@openshift-ci openshift-ci bot requested review from kyoto and PeterYurkovich May 30, 2025 15:27
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2025
@zhuje zhuje changed the title fix: ACM filtering and 'Export as CSV' link OU-829: fix ACM filtering and 'Export as CSV' link May 30, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 30, 2025

@zhuje: This pull request references OU-829 which is a valid jira issue.

In response to this:

JIRA

https://issues.redhat.com/browse/OU-829

Description

This is a backport of fixes resolved in the main branch.

  • ACM Alerting filtering
  • Add 'Export as CSV'

Process

  • Copy/Paste Changes from main branch > AlertsPage, which has already fixed these issues for 4.19.
  • Adjust for Patternfly 5 (HTML is slightly different to accommodate Patternfly 5 instead of Patternfly 6). Business logic should be the same as main branch > AlertsPage (as of May 30).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PeterYurkovich
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2025
Copy link
Contributor

openshift-ci bot commented May 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PeterYurkovich, zhuje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,zhuje]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@etmurasaki
Copy link
Contributor

/label qe-approved
tested on 4.15 and 4.18

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 30, 2025

@zhuje: This pull request references OU-829 which is a valid jira issue.

In response to this:

JIRA

https://issues.redhat.com/browse/OU-829

Description

This is a backport of fixes resolved in the main branch.

  • ACM Alerting filtering
  • Add 'Export as CSV'

Process

  • Copy/Paste Changes from main branch > AlertsPage, which has already fixed these issues for 4.19.
  • Adjust for Patternfly 5 (HTML is slightly different to accommodate Patternfly 5 instead of Patternfly 6). Business logic should be the same as main branch > AlertsPage (as of May 30).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PeterYurkovich
Copy link
Contributor

/label ux-approved

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label May 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c2fa250 into openshift:release-coo-0.4 May 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants