Skip to content

Conversation

falox
Copy link
Contributor

@falox falox commented Oct 6, 2025

Alerts were being sorted before filtering by the incident's time range, causing incorrect chronological order when some alert timestamps fell outside the range. Refactored to filter alerts first, then sort only the remaining alerts by their earliest visible timestamp.

Assisted-By: Claude

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2025

@falox: This pull request references OBSINTA-789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Alerts were being sorted before filtering by the incident's time range, causing incorrect chronological order when some alert timestamps fell outside the range. Refactored to filter alerts first, then sort only the remaining alerts by their earliest visible timestamp.

Assisted-By: Claude

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@falox
Copy link
Contributor Author

falox commented Oct 6, 2025

/cc @DavidRajnoha

@openshift-ci openshift-ci bot requested review from DavidRajnoha, kyoto and zhuje October 6, 2025 20:56
@falox
Copy link
Contributor Author

falox commented Oct 7, 2025

/label ux-approved

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label Oct 7, 2025
@falox
Copy link
Contributor Author

falox commented Oct 7, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2025

@falox: This pull request references OBSINTA-789 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Alerts were being sorted before filtering by the incident's time range, causing incorrect chronological order when some alert timestamps fell outside the range. Refactored to filter alerts first, then sort only the remaining alerts by their earliest visible timestamp.

Assisted-By: Claude

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jgbernalp
Copy link
Contributor

/lgtm

@jgbernalp
Copy link
Contributor

/override ci/prow/okd-scos-e2e-aws-ovn

Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: falox, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2025
Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

@jgbernalp: Overrode contexts on behalf of jgbernalp: ci/prow/okd-scos-e2e-aws-ovn

In response to this:

/override ci/prow/okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

@falox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ae93935 into openshift:main Oct 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants