-
Notifications
You must be signed in to change notification settings - Fork 34
OBSINTA-789: Sort alerts by start time #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBSINTA-789: Sort alerts by start time #577
Conversation
@falox: This pull request references OBSINTA-789 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @DavidRajnoha |
/label ux-approved |
/label qe-approved |
@falox: This pull request references OBSINTA-789 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
/override ci/prow/okd-scos-e2e-aws-ovn |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: falox, jgbernalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jgbernalp: Overrode contexts on behalf of jgbernalp: ci/prow/okd-scos-e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@falox: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Alerts were being sorted before filtering by the incident's time range, causing incorrect chronological order when some alert timestamps fell outside the range. Refactored to filter alerts first, then sort only the remaining alerts by their earliest visible timestamp.
Assisted-By: Claude