Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-23102: Revert #266 "OCPBUGS-21718: go.mod: bump golang.org/x/net to v0.17.0" #268

Closed
wants to merge 1 commit into from

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Nov 9, 2023

Reverts #266 ; tracked by OCPBUGS-23102

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

All metal jobs are broken and we don't have an obvious culprit, TRT is floating a few reverts for investigation.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

N/A

CC: @s-urbaniak

PR created by Revertomatic™️

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 9, 2023
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Jira Issue OCPBUGS-23102, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #266 ; tracked by OCPBUGS-23102

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

All metal jobs are broken and we don't have an obvious culprit, TRT is floating a few reverts for investigation.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

N/A

CC: @s-urbaniak

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

stbenjam commented Nov 9, 2023

/hold
/payload-job periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-ipv6

@openshift-ci openshift-ci bot requested review from deads2k and stlaz November 9, 2023 13:11
Copy link

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stbenjam
Once this PR has been reviewed and has the lgtm label, please assign stlaz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2023
Copy link

openshift-ci bot commented Nov 9, 2023

@stbenjam: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/78a5a300-7f01-11ee-9b57-8ae3bf59e63a-0

@stbenjam
Copy link
Member Author

stbenjam commented Nov 9, 2023

/close

It was openshift/origin#28389

@stbenjam stbenjam closed this Nov 9, 2023
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Jira Issue OCPBUGS-23102. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Reverts #266 ; tracked by OCPBUGS-23102

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

All metal jobs are broken and we don't have an obvious culprit, TRT is floating a few reverts for investigation.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

N/A

CC: @s-urbaniak

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants