ob and obc will move to owned instead of required #424

jackyalbo · 2020-02-24T14:37:08Z

As part of not being dependent on community operators in downstream
fix to BZ1798571
upstream NooBaa will still require lib_bucket_provisionser as a dependency

openshift-ci-robot · 2020-02-24T14:38:19Z

Hi @jackyalbo. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

umangachapagain · 2020-02-25T15:13:33Z

/ok-to-test

umangachapagain

Is this fix only for ocs-operator case?
This change should ideally come from NooBaa operator itself. We should not be overriding it here.

guymguym · 2020-02-25T15:36:20Z

@umangachapagain That can't come from NooBaa itself.
Upstream noobaa will still require those CRDs and get them through OLM dependency on the lib-bucket-provisioner operator (CRD only operator).
However downstream we don't want OCS to depend on a community operator and therefore we decide to own those CRDs by OCS.

jackyalbo · 2020-02-25T18:15:39Z

/retest

umangachapagain

Will the new CRDs be persisted across make gen-latest-csv ?
I have a feeling it will not be included during new bundle creation as we fetch our CRDs during build from NooBaa and Rook. We might need to add these CRDs to /deploy/crds/ directory.

guymguym · 2020-02-26T06:57:46Z

Yes it does. We still get it the same way, just now we patch it from required to owned.

guymguym · 2020-02-26T07:00:58Z

But @umangachapagain you’re right that @jackyalbo should make sure that those crd files themselves are really updated from noobaa operator during CSV merge, and not statically stored in OCS git.

jackyalbo · 2020-02-26T09:26:48Z

they are updated by the operator - was added by running "make gen-latest-csv"

umangachapagain

/lgtm

Just would be neat to have "go.mod / go.sum" changes in a separate commit.

jackyalbo · 2020-02-26T13:50:42Z

fixed to 2 separate commits

jarrpa · 2020-02-26T20:51:58Z

tools/csv-merger/csv-merger.go

 			ocsCSV.Spec.CustomResourceDefinitions.Owned = append(ocsCSV.Spec.CustomResourceDefinitions.Owned, csvStruct.Spec.CustomResourceDefinitions.Owned...)
-			ocsCSV.Spec.CustomResourceDefinitions.Required = append(ocsCSV.Spec.CustomResourceDefinitions.Required, csvStruct.Spec.CustomResourceDefinitions.Required...)
+
+			for _, definition := range csvStruct.Spec.CustomResourceDefinitions.Required {


Is this in place because the NooBaa CSV we're importing isn't updated to reflect this change? If so, shouldn't the change be in NooBaa?

umangachapagain · 2020-02-27T09:02:07Z

@umangachapagain That can't come from NooBaa itself.
Upstream noobaa will still require those CRDs and get them through OLM dependency on the lib-bucket-provisioner operator (CRD only operator).

If lib-bucket-provisioner operator is gone, how will NooBaa operator function upstream?

guymguym · 2020-02-27T09:03:52Z

@umangachapagain lib-bucket-provisioner is only removed from cumminity-operators for Openshift, not from upstream-community-operators for Kubernetes.

As part of not being dependent on community operators BZ1798571 Signed-off-by: jackyalbo <jalbo@redhat.com>

Signed-off-by: jackyalbo <jalbo@redhat.com>

openshift-ci-robot · 2020-03-05T15:13:53Z

@jackyalbo: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/ocs-operator-e2e-aws	`fd99074`	link	`/test ocs-operator-e2e-aws`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jarrpa · 2020-03-05T21:23:03Z

/lgtm

openshift-ci-robot · 2020-03-05T21:24:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackyalbo, jarrpa, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jarrpa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

obnoxxx · 2020-03-25T23:53:33Z

/cherry-pick release-4.4

openshift-cherrypick-robot · 2020-03-25T23:53:40Z

@obnoxxx: new pull request created: #458

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2020

openshift-ci-robot requested review from davidvossel and jarrpa February 24, 2020 14:42

jackyalbo force-pushed the ocs-noobaa-fixes branch from ba75a88 to eb6cb68 Compare February 25, 2020 15:19

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2020

jackyalbo force-pushed the ocs-noobaa-fixes branch from eb6cb68 to 84c0d50 Compare February 25, 2020 15:25

umangachapagain suggested changes Feb 25, 2020

View reviewed changes

umangachapagain reviewed Feb 26, 2020

View reviewed changes

umangachapagain approved these changes Feb 26, 2020

View reviewed changes

openshift-ci-robot assigned umangachapagain Feb 26, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020

jackyalbo force-pushed the ocs-noobaa-fixes branch from 84c0d50 to 1194294 Compare February 26, 2020 13:46

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020

jarrpa reviewed Feb 26, 2020

View reviewed changes

jackyalbo added 2 commits March 5, 2020 15:13

ob and obc will move to owned insted of required

caf931f

As part of not being dependent on community operators BZ1798571 Signed-off-by: jackyalbo <jalbo@redhat.com>

updating go.sum

fd99074

Signed-off-by: jackyalbo <jalbo@redhat.com>

jackyalbo force-pushed the ocs-noobaa-fixes branch from 1194294 to fd99074 Compare March 5, 2020 13:13

openshift-ci-robot assigned jarrpa Mar 5, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2020

openshift-merge-robot merged commit e021528 into red-hat-storage:master Mar 5, 2020

umangachapagain mentioned this pull request Mar 9, 2020

Hide ObjectBuckets & ObjectBucketClaims APIs #438

Merged

jackyalbo mentioned this pull request Mar 10, 2020

Bug 1798571: ob and obc will move to owned instead of required #441

Closed

umangachapagain mentioned this pull request Mar 11, 2020

Bug 1798571: OB/OBC CRD not marked as Internal #439

Closed

openshift-cherrypick-robot mentioned this pull request Mar 25, 2020

Bug 1798571: [release-4.4] ob and obc will move to owned instead of required #458

Closed

obnoxxx mentioned this pull request Mar 26, 2020

Bug 1798571: [release-4.4] Make ObjectBucket & ObjectBucketClaim CRs owned and hide their APIs #460

Merged

obnoxxx mentioned this pull request Jun 30, 2020

Move ObjectBucket and ObjectBucketClaim CRDs to owned instead of required. #593

Merged

openshift-ci-robot mentioned this pull request Jun 30, 2020

Bug 1798571: Release 4.5: owning ob and obc crds #594

Merged

ob and obc will move to owned instead of required #424

ob and obc will move to owned instead of required #424

Uh oh!

Conversation

jackyalbo commented Feb 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 24, 2020

Uh oh!

umangachapagain commented Feb 25, 2020

Uh oh!

umangachapagain left a comment

Choose a reason for hiding this comment

Uh oh!

guymguym commented Feb 25, 2020

Uh oh!

jackyalbo commented Feb 25, 2020

Uh oh!

umangachapagain left a comment

Choose a reason for hiding this comment

Uh oh!

guymguym commented Feb 26, 2020

Uh oh!

guymguym commented Feb 26, 2020

Uh oh!

jackyalbo commented Feb 26, 2020

Uh oh!

umangachapagain left a comment

Choose a reason for hiding this comment

Uh oh!

jackyalbo commented Feb 26, 2020

Uh oh!

jarrpa Feb 26, 2020

Choose a reason for hiding this comment

Uh oh!

umangachapagain commented Feb 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guymguym commented Feb 27, 2020

Uh oh!

openshift-ci-robot commented Mar 5, 2020

Uh oh!

jarrpa commented Mar 5, 2020

Uh oh!

openshift-ci-robot commented Mar 5, 2020

Uh oh!

obnoxxx commented Mar 25, 2020

Uh oh!

openshift-cherrypick-robot commented Mar 25, 2020

Uh oh!

Uh oh!

jackyalbo commented Feb 24, 2020 •

edited

Loading

umangachapagain commented Feb 27, 2020 •

edited

Loading