Skip to content

Bug 1862449: [release-4.5] Create only those StorageClasses which are provided in the external input file #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 21, 2020
Merged

Bug 1862449: [release-4.5] Create only those StorageClasses which are provided in the external input file #719

merged 9 commits into from
Aug 21, 2020

Conversation

jarrpa
Copy link
Member

@jarrpa jarrpa commented Aug 21, 2020

This is a backport of PR #701. Unfortunately, it required the backport of some additional refactoring as well.

crombus and others added 9 commits August 21, 2020 16:13
@crombus @jarrpa
refactor: moving the initialization_reconciler.go functions to new/se…
faddaeb 
…parate files.

Signed-off-by: crombus <pkundra@redhat.com>
@crombus @jarrpa
refactor: reduce gocyclo complexity in cephobjectstores.go
8f8e1fc
@crombus @jarrpa
refactor: reduce gocyclo complexity in cephobjectstoreusers.go
4f32c19 
(cherry picked from commit 05f6fd5)
@crombus @jarrpa
refactor: reduce gocyclo complexity in external_resources.go
541985a 
(cherry picked from commit c36f43d)
@vbnrh @jarrpa
Refactor: initialization_reconciler_test.go
68767ce 
Splits the file into several test file for each resource (cephblockpools, cephfs etc..)

Signed-off-by: Vineet Badrinath <vbadrina@redhat.com>
@aruniiird @jarrpa
Correcting gofmt issue in the file
c864546 
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
@aruniiird @jarrpa
Correcting some comments
4fec9c9 
Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
@aruniiird @jarrpa
Create only those StorageClasses provided in the external JSON input …
1ab8488 
…file

In External Cluster mode, create only those StorageClasses which are
provided in JSON input file.

Added 'setRookCSICephFS' function, which could toggle Rook CephFS CSI driver,
which will enable or disable (the driver) according to whether CephFS
storageclass is available (or not) in the external JSON input.

Corrected the tests to work with latest changes.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
@aruniiird @jarrpa
Adding tests to cover optional StorageClass changes
06aa84d 
Added new tests for checking optional external JSON input.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 21, 2020
@openshift-ci-robot
Copy link

@jarrpa: This pull request references Bugzilla bug 1862449, which is invalid:

  • expected dependent Bugzilla bug 1857304 to target a release in 4.6.0, 4.6.z, but it targets "OCS 4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1862449: [release-4.5] Create only those StorageClasses which are provided in the external input file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 21, 2020
@jarrpa jarrpa added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 21, 2020
@openshift-ci-robot
Copy link

@jarrpa: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-latest-csv 06aa84d link /test verify-latest-csv

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

obnoxxx
obnoxxx approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: obnoxxx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 21, 2020
@jarrpa jarrpa merged commit 9c63f85 into red-hat-storage:release-4.5 Aug 21, 2020
@openshift-ci-robot
Copy link

@jarrpa: All pull requests linked via external trackers have merged: openshift/ocs-operator#719, openshift/ocs-operator#669, openshift/ocs-operator#661. Bugzilla bug 1862449 has been moved to the MODIFIED state.

In response to this:

Bug 1862449: [release-4.5] Create only those StorageClasses which are provided in the external input file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jarrpa jarrpa deleted the pr701-4.5-backport branch August 24, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obnoxxx obnoxxx obnoxxx approved these changes

@davidvossel davidvossel Awaiting requested review from davidvossel

@mhrivnak mhrivnak Awaiting requested review from mhrivnak

Assignees

@obnoxxx obnoxxx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jarrpa @openshift-ci-robot @obnoxxx @crombus @vbnrh @aruniiird