List all urls even if they are only in local config or only in cluster

[kadel]

What is the purpose of this change? What does it change?

This PR is adding State field into URL structs. Url can be in 3 different states:

• Pushed: Url is present in local config and also on the cluster
• Locally Deleted: Url is present on the cluster but not in the local config
• Not Pushed: Url is present in the local config but not on the cluster

This is also reflected in the output

Was the change discussed in an issue?

fixes #1893
This PR replaces #1978

How to test changes?

Create some urls, and delete them without pushing.
You should see each url reporting correct state

odo create java:8
odo url create url0 --port 8080
odo url create url1 --port 8443
odo push
odo url delete url1
odo url create url2 --port 8778

# now you should see each url in a different state
odo url list

▶ odo url list
Found the following URLs for component java-spring-boot-yelj in application app:
NAME                           STATE               URL                                                                                       PORT
java-spring-boot-yelj-8080     Pushed              http://java-spring-boot-yelj-8080-app-tkmyproject.apps.tkral.devcluster.openshift.com     8080
java-spring-boot-yelj-8443     Locally Deleted     http://java-spring-boot-yelj-8443-app-tkmyproject.apps.tkral.devcluster.openshift.com     8443
java-spring-boot-yelj-8778     Not Pushed          ://


There are local changes. Please run 'odo push'.%

▶ odo url list -o json | jq .
{
  "kind": "List",
  "apiVersion": "odo.openshift.io/v1alpha1",
  "metadata": {},
  "items": [
    {
      "kind": "url",
      "apiVersion": "odo.openshift.io/v1alpha1",
      "metadata": {
        "name": "java-spring-boot-yelj-8080",
        "creationTimestamp": null
      },
      "spec": {
        "host": "java-spring-boot-yelj-8080-app-tkmyproject.apps.tkral.devcluster.openshift.com",
        "protocol": "http",
        "port": 8080
      },
      "status": {
        "state": "Pushed"
      }
    },
    {
      "kind": "url",
      "apiVersion": "odo.openshift.io/v1alpha1",
      "metadata": {
        "name": "java-spring-boot-yelj-8443",
        "creationTimestamp": null
      },
      "spec": {
        "host": "java-spring-boot-yelj-8443-app-tkmyproject.apps.tkral.devcluster.openshift.com",
        "protocol": "http",
        "port": 8443
      },
      "status": {
        "state": "Locally Deleted"
      }
    },
    {
      "kind": "url",
      "apiVersion": "odo.openshift.io/v1alpha1",
      "metadata": {
        "name": "java-spring-boot-yelj-8778",
        "creationTimestamp": null
      },
      "spec": {
        "port": 8778
      },
      "status": {
        "state": "Not Pushed"
      }
    }
  ]
}

[dharmit]

• creationTimestamp is empty in the metadata section of json output. Is it not possible to set it? Is it not of use to the dev? Is it there for future purpose? If it's not supposed to have the value, why have it in the metadata?
• Code looks good, but can use a few comments.

[kadel]

• creationTimestamp is empty in the metadata section of json output. Is it not possible to set it? Is it not of use to the dev? Is it there for future purpose? If it's not supposed to have the value, why have it in the metadata?

That comes from reusing k8s metav1.ObjectMeta, currently we have it empty everywhere, and we can't get rid of it, unless we create our own ObjectMeta In future we might start using it, but for now, it is like this everywhere.

[kadel]

/retest

error: could not run steps: step root failed: could not wait for build: the build root failed after 18s with reason PullBuilderImageFailed: Failed pulling builder image.
 Pulling image registry.svc.ci.openshift.org/openshift/release:golang-1.11 ...
error: build error: failed to pull image: received unexpected HTTP status: 500 Internal Server Error

[kadel]

/retest

2019/08/26 15:52:58 Submitted failure event to sentry (id=e9e89ca9e8054c18a73209af210c988b)
error: could not run steps: step root failed: could not wait for build: the build root failed after 42s with reason PullBuilderImageFailed: Failed pulling builder image.
 Pulling image registry.svc.ci.openshift.org/openshift/release:golang-1.11 ...
error: build error: failed to pull image: received unexpected HTTP status: 500 Internal Server Error

[amitkrout]

Integration test script update looks good to me. @kadel However UTs coverage is not done properly for newly added function.

[kadel]

Integration test script update looks good to me. @kadel However UTs coverage is not done properly for newly added function.

Due to the current structure, it is almost impossible to write a unit test for url.List function :-( This will require big config package refactoring. All the scenarios should be covered in integration test.

[cdrage]

Works and code LGTM! I don't see any issues as well as -o json works well.

~/nodejs-ex  master ✗                                                                                                                                                                                                                                                  317d ⚑ ◒  
▶ odo url list
Found the following URLs for component nodejs-nodejs-ex-sgwk in application app:
NAME                           STATE      URL                                                                                PORT
nodejs-nodejs-ex-sgwk-8080     Pushed     [REDACTED]     8080
url0                           Pushed     [REDACTED]                           8080

~/nodejs-ex  master ✗                                                                                                                                                                                                                                                  317d ⚑ ◒  
▶ odo url delete url0
? Are you sure you want to delete the url url0 Yes
 ✓  URL url0 removed from the config file
To delete URL on the OpenShift Cluster, please use `odo push`

~/nodejs-ex  master ✗                                                                                                                                                                                                                                                  317d ⚑ ◒  
▶ odo url list
Found the following URLs for component nodejs-nodejs-ex-sgwk in application app:
NAME                           STATE               URL                                                                                PORT
nodejs-nodejs-ex-sgwk-8080     Pushed              [REDACTED]     8080
url0                           Locally Deleted     [REDACTED]                           8080

There are local changes. Please run 'odo push'.

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/component/OWNERS [cdrage]
• pkg/occlient/OWNERS [cdrage]
• pkg/odo/OWNERS [cdrage]
• pkg/url/OWNERS [cdrage]
• tests/OWNERS [cdrage]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dharmit]

/lgtm