Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ci #2339

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Fix Ci #2339

merged 1 commit into from
Jan 6, 2021

Conversation

mjudeikis
Copy link
Contributor 

NONE
  • Fix Ci for secret mounting
  • Remove generation validation for now

@openshift-ci-robot openshift-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 6, 2021
@mjudeikis mjudeikis requested a review from jim-minter January 6, 2021 09:41
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2021
@mjudeikis
Copy link
Contributor Author

/retest

jim-minter
jim-minter approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@jim-minter jim-minter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following changes should be reverted in a future PR:

  • make verify / validate-generated
  • xtrace in ci-prepare.sh
  • early return in ci-prepare.sh

@jim-minter
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jim-minter, mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jim-minter,mjudeikis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jim-minter, mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jim-minter,mjudeikis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mjudeikis mjudeikis merged commit b7c586a into openshift:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-minter jim-minter jim-minter approved these changes

@asalkeld asalkeld Awaiting requested review from asalkeld

@nilsanderselde nilsanderselde Awaiting requested review from nilsanderselde

Assignees

@jim-minter jim-minter

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjudeikis @jim-minter @openshift-ci-robot