Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cert rotation fix #2361

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Cert rotation fix #2361

merged 3 commits into from
Sep 29, 2021

Conversation

m1kola
Copy link
Contributor

@m1kola m1kola commented Sep 27, 2021 •
edited
Loading

SDN certification rotation was missing

Fixes cluster certificate rotation: SDN certificate also needs to be rotated.

@m1kola m1kola changed the base branch from master to release-v22 September 27, 2021 14:23
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 27, 2021
@mjudeikis
Copy link
Contributor

/retest

2 similar comments
@mjudeikis
Copy link
Contributor

/retest

@mjudeikis
Copy link
Contributor

/retest

@m1kola m1kola changed the base branch from release-v22 to master September 28, 2021 09:03
Mikalai Radchuk added 2 commits September 28, 2021 11:29
Fixes cert rotation
17b2cb3 
SDN certification rotation was missing
Replaces outdated make secret
fb8dca7 
Old way of getting secrets via make secret doesn't work now
becasue the cluster which stored secrets got decommissioned.
@mjudeikis
Copy link
Contributor

/retest

2 similar comments
@mjudeikis
Copy link
Contributor

/retest

@m1kola
Copy link
Contributor Author

m1kola commented Sep 28, 2021

/retest

Fixes OpenShift Broker App e2e test
48c8d2e 
Microsoft Docker Hub org deprecated and removed. Move to ACR
@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2021 •
edited
Loading

@m1kola: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
e2e-create 27e5bad link true /test e2e-create
e2e-scaleupdown 27e5bad link true /test e2e-scaleupdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1kola
Copy link
Contributor Author

m1kola commented Sep 28, 2021

/retest

@mjudeikis
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1kola, mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2021
@m1kola m1kola changed the title [WIP] Cert rotation fix Cert rotation fix Sep 29, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2021
@m1kola m1kola changed the title Cert rotation fix [WIP] Cert rotation fix Sep 29, 2021
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 29, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 29, 2021
@m1kola m1kola changed the title [WIP] Cert rotation fix Cert rotation fix Sep 29, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1eb4f33 into openshift:master Sep 29, 2021
@m1kola m1kola deleted the cert_rotation_fix branch September 29, 2021 08:38
@m1kola
Copy link
Contributor Author

m1kola commented Sep 29, 2021

/cherry-pick release-v22

@openshift-cherrypick-robot
Copy link

@m1kola: new pull request created: #2363

In response to this:

/cherry-pick release-v22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 29, 2021
Merged
@m1kola
Copy link
Contributor Author

m1kola commented Sep 29, 2021

/cherrypick release-v22

@openshift-cherrypick-robot
Copy link

@m1kola: new pull request could not be created: failed to create pull request against openshift/openshift-azure#release-v22 from head openshift-cherrypick-robot:cherry-pick-2361-to-release-v22: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-2361-to-release-v22."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick release-v22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@m1kola m1kola mentioned this pull request Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantomation grantomation Awaiting requested review from grantomation

@Makdaam Makdaam Awaiting requested review from Makdaam

Assignees

@mjudeikis mjudeikis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m1kola @mjudeikis @openshift-cherrypick-robot @openshift-merge-robot