Skip to content

Fix kubeconfig arg #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2022
Merged

Fix kubeconfig arg #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4ee5f2
Change --config arg to --kubeconfig
ellakk Feb 23, 2022
63d5db1
Adding ansible updates
bradmwilliams May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ you can specify many default contexts in the environment.
### Defaults when invoking `oc`
Establishing explicit contexts within an application will override these environment defaults.
- `OPENSHIFT_CLIENT_PYTHON_DEFAULT_OC_PATH` - default path to use when invoking `oc`
- `OPENSHIFT_CLIENT_PYTHON_DEFAULT_CONFIG_PATH` - default `--config` argument
- `OPENSHIFT_CLIENT_PYTHON_DEFAULT_CONFIG_PATH` - default `--kubeconfig` argument
- `OPENSHIFT_CLIENT_PYTHON_DEFAULT_API_SERVER` - default `--server` argument
- `OPENSHIFT_CLIENT_PYTHON_DEFAULT_CA_CERT_PATH` - default `--cacert` argument
- `OPENSHIFT_CLIENT_PYTHON_DEFAULT_PROJECT` - default `--namespace` argument
Expand Down
2 changes: 1 addition & 1 deletion ansible/rebuild_module.digest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7117af22373867e9f3ec3c0964ccd0ee -
2ddbee21a5c0456525d2fb662a4f1b01 -
2 changes: 1 addition & 1 deletion ansible/roles/openshift_client_python/library/openshift_client_python.py
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/openshift/action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def oc_action(context, verb, cmd_args=None, all_namespaces=False, no_namespace=F
references = {}

if context.get_kubeconfig_path() is not None:
cmds.append("--config=%s" % context.get_kubeconfig_path())
cmds.append("--kubeconfig=%s" % context.get_kubeconfig_path())

if context.get_api_url() is not None:
url = context.get_api_url()
Expand Down
2 changes: 1 addition & 1 deletion packages/openshift/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ def api_server(api_url=None, ca_cert_path=None, kubeconfig_path=None):
Contexts can be nested. The most immediate ancestor cluster context
will define the API server targeted by an action.
:param api_url: The oc --server argument to use.
:param kubeconfig_path: The oc --config argument to use.
:param kubeconfig_path: The oc --kubeconfig argument to use.
:return: The context object. Can be safely ignored.
"""

Expand Down