Skip to content

Fix APIObject ignoring context override #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Fix APIObject ignoring context override #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1e80f1
Fix APIObject ignoring context override
pehala Jun 10, 2022
10f58e5
Rebuild ansible module
pehala Jun 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ansible/rebuild_module.digest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0f98b612b97ffcc98304fc9581a8727a -
45e5927b24842946eaf6fab1a145810f -
2 changes: 1 addition & 1 deletion ansible/roles/openshift_client_python/library/openshift_client_python.py
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/openshift/apiobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def __init__(self, dict_to_model=None, string_to_model=None, context=None):
# make sure to force a namespace.

self.context = copy.copy(context if context else cur_context())
self.context.project_name = self.namespace(None)
self.context.project_name = self.namespace(self.context.project_name)

def as_dict(self):
"""
Expand Down
7 changes: 7 additions & 0 deletions packages/openshift/test_apiobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import unittest

from openshift import Context
from .apiobject import APIObject


Expand All @@ -12,6 +13,12 @@ def test_empty(self):
self.assertEqual(obj.as_json(), '{}')
self.assertIsNone(obj.context.project_name)

def test_context(self):
context = Context()
context.project_name = "my-project"
obj = APIObject(context=context)
self.assertEqual(obj.context.project_name, context.project_name)


if __name__ == '__main__':
unittest.main()