Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The problem with relative xref, illustrated #31991

Closed
wants to merge 1 commit into from

Conversation

jboxman
Copy link
Contributor

@jboxman jboxman commented Apr 28, 2021

Interactive fail.

@jboxman jboxman self-assigned this Apr 28, 2021
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 28, 2021
@netlify
Copy link

netlify bot commented Apr 28, 2021

Deploy preview for osdocs ready!

Built with commit 6631b20

https://deploy-preview-31991--osdocs.netlify.app

@@ -0,0 +1,4 @@
[id="hello"]
Copy link
Contributor

@vikram-redhat vikram-redhat Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing context, which causes a problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikram-redhat, oh, yeah, but was useful to confirm that injecting a relative path attribute does produce valid links locally regardless of where an assembly lives.

@jboxman jboxman closed this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants