OADP-447: PVC Snapshot restore does not work if PVC requested size does not match disk capacity #45986
Conversation
openshift-ci
bot
added
the
size/XS
| @@ -14,6 +14,7 @@ You restore a `Backup` custom resource (CR) by creating a `Restore` CR. | |||
| * You must install the OpenShift API for Data Protection (OADP) Operator. | |||
| * The `DataProtectionApplication` CR must be in a `Ready` state. | |||
| * You must have a Velero `Backup` CR. | |||
| * Ensure that PVC capacity at backup time matches the requested size, adjusting the requested size to match capacity. | |||
There was a problem hiding this comment.
Ensure that the PV capacity maybe? PVC is the request...
RichardHoch
force-pushed
the
pvc_restore
branch
2 times, most recently
from
e8bac25
to
04eb852
Compare
|
lgtm |
| @@ -14,6 +14,7 @@ You restore a `Backup` custom resource (CR) by creating a `Restore` CR. | |||
| * You must install the OpenShift API for Data Protection (OADP) Operator. | |||
| * The `DataProtectionApplication` CR must be in a `Ready` state. | |||
| * You must have a Velero `Backup` CR. | |||
| * Ensure that PV capacity at backup time matches the requested size, adjusting the requested size to match capacity. | |||
There was a problem hiding this comment.
I would suggest removing the bit after the comma. It seems repetitive of what you have in the first part of the sentence.
| * Ensure that PV capacity at backup time matches the requested size, adjusting the requested size to match capacity. | |
| * Ensure that persistent volume (PV) capacity at backup time matches the requested size. |
There was a problem hiding this comment.
I raised this issue with the SME who said that "It may not be obvious to average user who maybe conscious of space requested."
There was a problem hiding this comment.
I think keeping the clause as is still presents confusion. I have played with the wording a bit. what do you think of:
| * Ensure that PV capacity at backup time matches the requested size, adjusting the requested size to match capacity. | |
| * Ensure to adjust the requested size so the persistent volume (PV) capacity matches the requested size at backup time. |
| @@ -14,6 +14,7 @@ You restore a `Backup` custom resource (CR) by creating a `Restore` CR. | |||
| * You must install the OpenShift API for Data Protection (OADP) Operator. | |||
| * The `DataProtectionApplication` CR must be in a `Ready` state. | |||
| * You must have a Velero `Backup` CR. | |||
| * Ensure that PV capacity at backup time matches the requested size, adjusting the requested size to match capacity. | |||
There was a problem hiding this comment.
I think keeping the clause as is still presents confusion. I have played with the wording a bit. what do you think of:
| * Ensure that PV capacity at backup time matches the requested size, adjusting the requested size to match capacity. | |
| * Ensure to adjust the requested size so the persistent volume (PV) capacity matches the requested size at backup time. |
…es not match disk capacity
maxwelldb
added
the
peer-review-done
|
/cherry-pick enterprise-4.6 |
|
/cherry-pick enterprise-4.7 |
|
/cherry-pick enterprise-4.8 |
|
/cherry-pick enterprise-4.9 |
|
/cherry-pick enterprise-4.10 |
|
/cherry-pick enterprise-4.11 |
|
@maxwelldb: new pull request created: #46050 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@maxwelldb: new pull request created: #46051 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@maxwelldb: new pull request created: #46052 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@maxwelldb: new pull request created: #46054 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@maxwelldb: new pull request created: #46055 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@maxwelldb: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.11 from head openshift-cherrypick-robot:cherry-pick-45986-to-enterprise-4.11: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.11 |
|
@maxwelldb: new pull request created: #46077 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OADP 1.0.3, OCP 4.6+
Resolves https://issues.redhat.com/browse/OADP-447 by adding a prerequisite to the procedure in section 4.3.1 of Backup and Restore
Preview:
Last prerequisite