Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-952: Clarify openshift-monitoring namespace requirement for m… #75015

Merged
merged 1 commit into from
Apr 25, 2024
Merged

OBSDOCS-952: Clarify openshift-monitoring namespace requirement for m… #75015

merged 1 commit into from
Apr 25, 2024

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Apr 23, 2024 •
edited
Loading

Version(s): enterprise-4.12 and later

Issue: OBSDOCS-952

Links to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-952 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): enterprise-4.12 and later

Issue: OBSDOCS-952

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 23, 2024
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 23, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 23, 2024 •
edited
Loading

🤖 Thu Apr 25 07:15:34 - Prow CI generated the docs preview:

https://75015--ocpdocs-pr.netlify.app/openshift-dedicated/latest/observability/monitoring/managing-alerts.html
https://75015--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/managing-alerts.html
https://75015--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/monitoring/managing-alerts.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-952 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): enterprise-4.12 and later

Issue: OBSDOCS-952

Links to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@juzhao
Copy link

juzhao commented Apr 23, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024 •
edited by openshift-ci bot
Loading

@eromanova97: This pull request references OBSDOCS-952 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): enterprise-4.12 and later

Issue: OBSDOCS-952

Links to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jan--f
Copy link
Contributor

jan--f commented Apr 24, 2024

/lgtm

@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 24, 2024
@aspauldi
Copy link

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 24, 2024
aspauldi
aspauldi reviewed Apr 24, 2024
View reviewed changes
Copy link

@aspauldi aspauldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of small things that I am asking @ousleyp to take a look at, as I am still new to peer reviewing. Thanks!

modules/monitoring-managing-core-platform-alerting-rules.adoc Outdated Show resolved Hide resolved
modules/monitoring-modifying-core-platform-alerting-rules.adoc Outdated Show resolved Hide resolved
ousleyp
ousleyp reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@ousleyp ousleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of clarity nits; please let me know if you have any questions. Otherwise, it's looking good. Thanks!

(Secondary review for @aspauldi)

modules/monitoring-modifying-core-platform-alerting-rules.adoc Outdated Show resolved Hide resolved
modules/monitoring-modifying-core-platform-alerting-rules.adoc Outdated Show resolved Hide resolved
@aspauldi
Copy link

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 24, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 25, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 25, 2024

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 25, 2024
@michaelryanpeter
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 25, 2024
@michaelryanpeter michaelryanpeter added this to the Continuous Release milestone Apr 25, 2024
@michaelryanpeter michaelryanpeter merged commit 3394eef into openshift:main Apr 25, 2024
3 checks passed
@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.16

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.15

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.14

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.13

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #75153

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 25, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #75154

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 25, 2024
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #75155

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #75156

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 25, 2024
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #75157

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 25, 2024
Merged
@eromanova97 eromanova97 deleted the OBSDOCS-952 branch April 26, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@michaelryanpeter michaelryanpeter michaelryanpeter left review comments

@aspauldi aspauldi aspauldi left review comments

@juzhao juzhao juzhao left review comments

@ousleyp ousleyp ousleyp left review comments

Assignees

@jan--f jan--f

@juzhao juzhao

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
10 participants
@eromanova97 @openshift-ci-robot @ocpdocs-previewbot @juzhao @jan--f @aspauldi @michaelryanpeter @openshift-cherrypick-robot @ousleyp @ocpdocs-vale-bot