Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS#16643: Updated storage class name in YAML configurations #75123

Merged
merged 1 commit into from
Apr 29, 2024
Merged

OCPBUGS#16643: Updated storage class name in YAML configurations #75123

merged 1 commit into from
Apr 29, 2024

Conversation

sr1kar99
Copy link
Contributor

@sr1kar99 sr1kar99 commented Apr 25, 2024 •
edited
Loading

Version(s):
4.12+

Issue:
OCPBUGS-16643

Link to docs preview:
Preview

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 25, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 25, 2024 •
edited
Loading

🤖 Mon Apr 29 06:36:23 - Prow CI generated the docs preview:

https://75123--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage/persistent_storage_local/persistent-storage-local.html

@sr1kar99
Copy link
Contributor Author

Hi @jsafrane
Could you please review this PR?
Thanks!

@jsafrane
Copy link
Contributor

lgtm from storage engineering point of view.

@sr1kar99
Copy link
Contributor Author

@duanwei33
Could you please review this PR?
Thanks!

@duanwei33
Copy link

duanwei33 commented Apr 26, 2024 •
edited
Loading

Hi @sr1kar99, thanks for the fix!
I think we need to update the following two places when verifying persistent volumes with Example output, the pv's storageclass name should be the same one defined in LSO CR (currently they are all local-sc)

https://github.com/openshift/openshift-docs/pull/75123/files#diff-82096208e0c1757b8d751aed72124301f6df289a29f72e243a8dda6cd3c2503cL109
-> is using local-storage
https://github.com/openshift/openshift-docs/pull/75123/files#diff-903db9d256758dca30cd6acced08966e4fc9ab4f44e57e9d045f137217d5b658L143
-> is using example-storageclass

Others look good to me.

@sr1kar99 sr1kar99 force-pushed the 16643-storageclass-name-example-update branch from 8dd8d22 to af0e275 Compare April 29, 2024 06:32
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 29, 2024

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sr1kar99
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 29, 2024
@dfitzmau
Copy link
Contributor

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 29, 2024
@dfitzmau
Copy link
Contributor

dfitzmau commented Apr 29, 2024 •
edited
Loading

Hi @sr1kar99 . Jira will need story points, assigned to a sprint, version labels for 4.13+, and be moved to the POST status.

@dfitzmau
Copy link
Contributor

/remove-label peer-review-in-progress

/label peer-review-done

Nice work, @sr1kar99 . Just added some Jira-related comments. LGTM!

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 29, 2024
@lpettyjo
Copy link
Contributor

LGTM

@sr1kar99
Copy link
Contributor Author

/remove-label peer-review-in-progress

/label peer-review-done

Nice work, @sr1kar99 . Just added some Jira-related comments. LGTM!

Hi @dfitzmau
Thanks for the review! Updated JIRA as per the suggestions.

@sr1kar99
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 29, 2024
@mburke5678 mburke5678 added this to the Continuous Release milestone Apr 29, 2024
@mburke5678 mburke5678 merged commit 0d8b663 into openshift:main Apr 29, 2024
3 checks passed
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.12

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.13

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.14

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.15

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@mburke5678: #75123 failed to apply on top of branch "enterprise-4.12":

Applying: OCPBUGS#16643: Updated storage class name in YAML configurations
Using index info to reconstruct a base tree...
M	modules/persistent-storage-local-create-cr.adoc
M	modules/persistent-storage-local-discovery.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/persistent-storage-local-discovery.adoc
Auto-merging modules/persistent-storage-local-create-cr.adoc
CONFLICT (content): Merge conflict in modules/persistent-storage-local-create-cr.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS#16643: Updated storage class name in YAML configurations
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@mburke5678: #75123 failed to apply on top of branch "enterprise-4.13":

Applying: OCPBUGS#16643: Updated storage class name in YAML configurations
Using index info to reconstruct a base tree...
M	modules/persistent-storage-local-create-cr.adoc
M	modules/persistent-storage-local-discovery.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/persistent-storage-local-discovery.adoc
Auto-merging modules/persistent-storage-local-create-cr.adoc
CONFLICT (content): Merge conflict in modules/persistent-storage-local-create-cr.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS#16643: Updated storage class name in YAML configurations
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@mburke5678: #75123 failed to apply on top of branch "enterprise-4.14":

Applying: OCPBUGS#16643: Updated storage class name in YAML configurations
Using index info to reconstruct a base tree...
M	modules/persistent-storage-local-create-cr.adoc
M	modules/persistent-storage-local-discovery.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/persistent-storage-local-discovery.adoc
Auto-merging modules/persistent-storage-local-create-cr.adoc
CONFLICT (content): Merge conflict in modules/persistent-storage-local-create-cr.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS#16643: Updated storage class name in YAML configurations
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 29, 2024
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #75271

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #75272

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 29, 2024
Merged
This was referenced Apr 29, 2024
Merged
Merged
Merged
@sr1kar99
Copy link
Contributor Author

Hi @mburke5678
Cherry-picked to 4.12, 4.13, and 4.14.
Could you please merge these PRs?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
8 participants
@sr1kar99 @ocpdocs-previewbot @jsafrane @duanwei33 @dfitzmau @lpettyjo @mburke5678 @openshift-cherrypick-robot