Support configuration of Environment and Tolerations for operator subscriptions #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator subscriptions' design
|
This looks good to me! It's interesting seeing the Environment variables in a modal as opposed to a tab, but I think I understand why a modal maybe makes the most sense here. Only other comment I had is a super small nit, but we are updating the drag and drop icons to use PatternFly's fa-grip-vertical icon (PR:openshift/console#8848)! |
bmignano
approved these changes
May 4, 2021
Thanks! Updated that icon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator Subscription resources support users entering further config information about how the operator should be deployed or installed by OLM. These include Env/EnvFrom, Volumes, VolumeMounts, Tolerations and Resources, as seen in the OLM documentation for Subscription Config. Today that information can only be configured via YAML, however the console should support configuration of these as well when installing an operator.
With this design, specifically the configuration of Env/EnvFrom and Tolerations will be supported, as those are low-hanging-fruit since we already have console UI widgets to support editing those configs we can reuse. These will be surfaced under an 'advanced configuration' area on the Install Operator form, and also be surfaced in the operator detail's Subscription tab for editing purposes as well.
Design story: https://issues.redhat.com/browse/PD-960
@openshift/team-ux-leads
@openshift/team-ux-review (Administrator perspective)