[OSJC-157] Throw unauthorized exception when a 403 status is returned #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcantrill
added a commit
that referenced
this pull request
Apr 21, 2015
[OSJC-157] Throw unauthorized exception when a 403 status is returned
There was a problem hiding this comment.
I am pretty convinced that using an enum for api version is not the right tool at hand. Enums typically are the right tool for closed exhaustive choice whereas in API versions we clearly have an open ended choice. I would clearly switch to a class and move away from enum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adietish found our issue when reconnecting after eclipse session restart. Per my discussion with @maxandersen , im putting this into master