[OSJC-240] Set deploymentconfig env vars #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| String getName(); | ||
|
|
||
| String getValue(); |
There was a problem hiding this comment.
I don't think that's correct, looking at a pod, I can see
"env" : [
...
{
"name" : "OPENSHIFT_KUBE_PING_NAMESPACE",
"valueFrom" : {"fieldRef" : {
"apiVersion" : "v1",
"fieldPath" : "metadata.namespace"
}}
}
jcantrill
force-pushed
the
240_set_dc_env_vars
branch
from
711548f to
bf02be5
Compare
|
cc @fbricon updated |
|
Evaluated for javaclient test up to bf02be5 |
|
Java Client Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/71/) |
|
[merge] |
|
Java Client Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge-openshift-restclient-java/72/) |
|
Evaluated for javaclient merge up to bf02be5 |
openshift-bot
pushed a commit
that referenced
this pull request
Feb 26, 2016
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @fbricon
[test]