[OSJC-251] Allow library to read kubeconfig #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
Java Client Test Results: Running (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/129/) |
|
|
||
| @Override | ||
| public boolean isInsecureSkipTLSVerify() { | ||
| if(cluster.containsKey("insecure-skip-tls-verify")) { |
There was a problem hiding this comment.
I'd extract the identifiers to constants for reuse
|
other than the minors the PR seems fine. +1 |
jcantrill
force-pushed
the
251_read_config_file
branch
from
e3e8762 to
76dbcc5
Compare
|
[merge] |
|
Java Client Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/128/) |
|
Evaluated for javaclient merge up to 76dbcc5 |
|
Evaluated for javaclient test up to 76dbcc5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allows the reading of the kubeconfig file. It does not provide any immediate support for the client to consume because we have not locked down the usecase ATM for consuming the kubeconfig file.
cc @adietish @fbricon
Merging in for bases of any future work.