[OSJC-275] Add volumes to deploymentconfigs #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @adietish [test] |
adietish
requested changes
Oct 21, 2016
| return (T) source; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
dare to correct identation for great and consistent code formatting experience?
There was a problem hiding this comment.
fixed. Modified my IDE to replace all tabs with spaces
jcantrill
force-pushed
the
add_volumes_to_dc
branch
from
7abf67d to
6b346e9
Compare
|
[merge] |
|
Evaluated for javaclient merge up to 6b346e9 |
|
Evaluated for javaclient test up to 6b346e9 |
|
Java Client Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/284/) (Base Commit: b6062e8) |
|
Java Client Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/285/) (Base Commit: b93533d) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides convenience methods for adding volumes to the DC podspec