Upgrade kubernetes >= 12.0
#420
Conversation
|
Hi @hswong3i. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-ok-to-test
|
This PR is functioning with my https://build.opensuse.org/package/show/home:alvistack/kubernetes-client-python-19.15.0 as below:
Manually tested with:
P.S. I didn't test with Python 2 since v18.20.0b1 (see https://github.com/kubernetes-client/python/blob/master/CHANGELOG.md#v18200b1) already drop the support. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
hswong3i
force-pushed
the
python-kubernetes
branch
from
b89bbe8 to
8ecb656
Compare
|
@fabianvf since Python 2.7 already EOL, I also give some simple remove for |
hswong3i
force-pushed
the
python-kubernetes
branch
from
8ecb656 to
8c2f83f
Compare
With master branch we simply pin dependency with `kubernetes`, but now branch `release-0.12` having a hard limit with `kubernetes ~= 12.0`. BTW, https://github.com/kubernetes-client/python/releases/tag/v12.0.1 was released on 2020-11-10, where today least release is https://github.com/kubernetes-client/python/releases/tag/v19.15.0. This PR remove the upper limit with `kubernetes >= 12.0`. Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
force-pushed
the
python-kubernetes
branch
from
8c2f83f to
8cd3fd9
Compare
|
After enable all tests for all target supported Python >= 3.5, it turn out not installable for Python 3.5, see: According to https://endoflife.date/python, Python 3.5 already EOL since 2020-09-13, where following LTS OSs already support Python 3.6:
For the latest commit I give a drop for 3.5 :-S |
|
@DenverM80: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -1,5 +1,5 @@ | |||
| jinja2 | |||
| kubernetes ~= 12.0 | |||
| kubernetes >= 12.0 | |||
There was a problem hiding this comment.
This has gotten really far behind, but I'm wary to automatically upgrade X versions. WDYT about kubernetes ~= 21.7
It looks like they bump the X quite frequently though
There was a problem hiding this comment.
That’s why I use >=, when this PR introduced on 2021 Nov it was still 19.x, and now it is already 21.x.
Using ~= is basically a good idea, but seems not for case in here :-(
There was a problem hiding this comment.
From the other side, I may able to explain why python-kubernetes update its x. version but not x.y.
- Kubernetes API coming with a N/N-1 support policy for many years
- In case python-kubernetes need to sync its support with Kubernetes corresponding API version AND avoid end user incorrectly install a non-compatible version, they bump the x.
- In case we also hope to sync with python-kubernetes handling, then we should using both >= and < in our requirements AND/OR also having a x. release bump with similar testing policy
|
/lgtm |
|
/approve |
fabianvf
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: asmacdo, DenverM80, fabianvf, hswong3i The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With master branch we simply pin dependency with
kubernetes, but nowbranch
release-0.12having a hard limit withkubernetes ~= 12.0.BTW, https://github.com/kubernetes-client/python/releases/tag/v12.0.1
was released on 2020-11-10, where today least release is
https://github.com/kubernetes-client/python/releases/tag/v19.15.0.
This PR remove the upper limit with
kubernetes >= 12.0.Signed-off-by: Wong Hoi Sing Edison hswong3i@pantarei-design.com