Skip to content

Conversation

kuiwang02
Copy link
Contributor

Summary

This PR adds support for hypershift binary management and includes new test cases for OLM v0 on hypershift management clusters.

Changes

🔧 Hypershift Binary Management

  • Added automatic hypershift binary detection and installation with cross-process synchronization
  • Implemented file-based locking mechanism to prevent race conditions during parallel test execution
  • Added architecture validation (Linux x86-64) before binary extraction
  • Enhanced IsHypershiftMgmtCluster() helper function to reliably detect hypershift management clusters

Test Result

./openshift-tests run olmv0/extended/candidate/hypershift --monitor watch-namespaces --include-success 
I0930 12:57:07.221252 1301378 factory.go:195] Registered Plugin "containerd"
  I0930 12:57:07.244265 1301378 i18n.go:157] Setting language to en_US
  I0930 12:57:07.683530 1301378 binary.go:86] Found 8057 test specs
  I0930 12:57:07.684408 1301378 binary.go:91] 1018 test specs remain, after filtering out k8s
openshift-tests v4.1.0-10046-gc49344f
...
INFO[0184] Found 0 must-gather tests                    
started: 0/1/2 "[sig-operator][Jira:OLM] OLMv0 on hypershift mgmt PolarionID:45381-[Skipped:Disconnected]Support custom catalogs in hypershift"

started: 0/2/2 "[sig-operator][Jira:OLM] OLMv0 on hypershift mgmt PolarionID:45408-[Skipped:Disconnected]Eliminate use of imagestreams in catalog management"


passed: (13.1s) 2025-09-30T05:00:25 "[sig-operator][Jira:OLM] OLMv0 on hypershift mgmt PolarionID:45408-[Skipped:Disconnected]Eliminate use of imagestreams in catalog management"


passed: (1m46s) 2025-09-30T05:01:58 "[sig-operator][Jira:OLM] OLMv0 on hypershift mgmt PolarionID:45381-[Skipped:Disconnected]Support custom catalogs in hypershift"

Shutting down the monitor
Collecting data.
INFO[0291] Starting CollectData for all monitor tests   
INFO[0291]   Starting CollectData for [Monitor:watch-namespaces][Jira:"Test Framework"] monitor test watch-namespaces collection 
INFO[0291]   Finished CollectData for [Monitor:watch-namespaces][Jira:"Test Framework"] monitor test watch-namespaces collection 
INFO[0291] Finished CollectData for all monitor tests   
Computing intervals.
Evaluating tests.
Cleaning up.
INFO[0291] beginning cleanup                             monitorTest=watch-namespaces
Serializing results.
Writing to storage.
  m.startTime = 2025-09-30 13:00:11.624001444 +0800 CST m=+184.484828691
  m.stopTime  = 2025-09-30 13:01:58.457531636 +0800 CST m=+291.318358876
Processing monitorTest: watch-namespaces
  finalIntervals size = 4
  first interval time: From = 2025-09-30 13:00:11.625710705 +0800 CST m=+184.486537933; To = 2025-09-30 13:00:11.625710705 +0800 CST m=+184.486537933
  last interval time: From = 2025-09-30 13:01:58.45719622 +0800 CST m=+291.318023465; To = 2025-09-30 13:01:58.45719622 +0800 CST m=+291.318023465
Writing junits.
Writing JUnit report to e2e-monitor-tests__20250930-045711.xml
2 pass, 0 flaky, 0 skip (4m47s)

Assisted-by: Claude Code

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 30, 2025

@kuiwang02: This pull request references OCPQE-30781 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Summary

This PR adds support for hypershift binary management and includes new test cases for OLM v0 on hypershift management clusters.

Changes

🔧 Hypershift Binary Management

  • Added automatic hypershift binary detection and installation with cross-process synchronization
  • Implemented file-based locking mechanism to prevent race conditions during parallel test execution
  • Added architecture validation (Linux x86-64) before binary extraction
  • Enhanced IsHypershiftMgmtCluster() helper function to reliably detect hypershift management clusters

Test Result

./openshift-tests run olmv0/extended/candidate/hypershift --monitor watch-namespaces --include-success 
I0930 12:57:07.221252 1301378 factory.go:195] Registered Plugin "containerd"
 I0930 12:57:07.244265 1301378 i18n.go:157] Setting language to en_US
 I0930 12:57:07.683530 1301378 binary.go:86] Found 8057 test specs
 I0930 12:57:07.684408 1301378 binary.go:91] 1018 test specs remain, after filtering out k8s
openshift-tests v4.1.0-10046-gc49344f
...
INFO[0184] Found 0 must-gather tests                    
started: 0/1/2 "[sig-operator][Jira:OLM] OLMv0 on hypershift mgmt PolarionID:45381-[Skipped:Disconnected]Support custom catalogs in hypershift"

started: 0/2/2 "[sig-operator][Jira:OLM] OLMv0 on hypershift mgmt PolarionID:45408-[Skipped:Disconnected]Eliminate use of imagestreams in catalog management"


passed: (13.1s) 2025-09-30T05:00:25 "[sig-operator][Jira:OLM] OLMv0 on hypershift mgmt PolarionID:45408-[Skipped:Disconnected]Eliminate use of imagestreams in catalog management"


passed: (1m46s) 2025-09-30T05:01:58 "[sig-operator][Jira:OLM] OLMv0 on hypershift mgmt PolarionID:45381-[Skipped:Disconnected]Support custom catalogs in hypershift"

Shutting down the monitor
Collecting data.
INFO[0291] Starting CollectData for all monitor tests   
INFO[0291]   Starting CollectData for [Monitor:watch-namespaces][Jira:"Test Framework"] monitor test watch-namespaces collection 
INFO[0291]   Finished CollectData for [Monitor:watch-namespaces][Jira:"Test Framework"] monitor test watch-namespaces collection 
INFO[0291] Finished CollectData for all monitor tests   
Computing intervals.
Evaluating tests.
Cleaning up.
INFO[0291] beginning cleanup                             monitorTest=watch-namespaces
Serializing results.
Writing to storage.
 m.startTime = 2025-09-30 13:00:11.624001444 +0800 CST m=+184.484828691
 m.stopTime  = 2025-09-30 13:01:58.457531636 +0800 CST m=+291.318358876
Processing monitorTest: watch-namespaces
 finalIntervals size = 4
 first interval time: From = 2025-09-30 13:00:11.625710705 +0800 CST m=+184.486537933; To = 2025-09-30 13:00:11.625710705 +0800 CST m=+184.486537933
 last interval time: From = 2025-09-30 13:01:58.45719622 +0800 CST m=+291.318023465; To = 2025-09-30 13:01:58.45719622 +0800 CST m=+291.318023465
Writing junits.
Writing JUnit report to e2e-monitor-tests__20250930-045711.xml
2 pass, 0 flaky, 0 skip (4m47s)

Assisted-by: Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kuiwang02
Copy link
Contributor Author

/verified by @kuiwang02

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 30, 2025
@openshift-ci-robot
Copy link

@kuiwang02: This PR has been marked as verified by @kuiwang02.

In response to this:

/verified by @kuiwang02

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianzhangbjz
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2025
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, kuiwang02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2025
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@kuiwang02: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn a274436 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2c539ec into openshift:main Sep 30, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants