Skip to content

Bug 2100323: Fix legacy registries no longer working (#974) #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 23, 2022
Merged

Bug 2100323: Fix legacy registries no longer working (#974) #324

merged 5 commits into from
Jun 23, 2022

Conversation

perdasilva
Copy link
Contributor

Signed-off-by: perdasilva perdasilva@redhat.com
Upstream-repository: operator-registry
Upstream-commit: 79e8f2518d57040e604ef4a68c9edef199d7d653

@perdasilva
Create database copy in tmp directory (openshift#974)
b550db5 
Signed-off-by: perdasilva <perdasilva@redhat.com>
Upstream-repository: operator-registry
Upstream-commit: 79e8f2518d57040e604ef4a68c9edef199d7d653
@openshift-ci openshift-ci bot requested review from anik120 and gallettilance June 23, 2022 12:33
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@perdasilva perdasilva changed the title Create database copy in tmp directory (#974) Bug 2100323: Create database copy in tmp directory (#974) Jun 23, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@perdasilva: This pull request references Bugzilla bug 2100323, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

Bug 2100323: Create database copy in tmp directory (#974)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from Xia-Zhao-rh June 23, 2022 12:49
joelanford
joelanford approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
gallettilance
gallettilance approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@joelanford
Copy link
Member

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gallettilance, joelanford, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gallettilance,joelanford,perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva
Fix /tmp path (openshift#975)
cd819bb 
Signed-off-by: perdasilva <perdasilva@redhat.com>
Upstream-repository: operator-registry
Upstream-commit: d42dcfa2db71e1d64f3fce74faff713662c94eff
@perdasilva
use "" instead of /tmp (openshift#976)
738c154 
Signed-off-by: perdasilva <perdasilva@redhat.com>
Upstream-repository: operator-registry
Upstream-commit: b080d080c494e20caecc035ebd14177a2e8e7a58
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@joelanford
Copy link
Member

/hold cancel
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 23, 2022
@perdasilva
Copy link
Contributor Author

/test e2e-gcp-olm-flaky

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@perdasilva perdasilva changed the title Bug 2100323: Create database copy in tmp directory (#974) Bug 2100323: Fix legacy registries no longer working (#974) Jun 23, 2022
@perdasilva perdasilva mentioned this pull request Jun 23, 2022
Closed
@perdasilva
Copy link
Contributor Author

/retest-required

@perdasilva
Sec revert (#2808)
8adc804 
* Revert "Unpack job security updates (#2805)"

This reverts commit e568cde5b5f9c7c5c6847a3690ddc59eae6a1a01.

Signed-off-by: perdasilva <perdasilva@redhat.com>

* Revert "Update unpack job pod security (#2793)"

This reverts commit eedad287de8d2326e2ad1f701737df1fb8d38756.

Signed-off-by: perdasilva <perdasilva@redhat.com>

* Revert "Update CatalogSource Pod security context (#2782)"

This reverts commit 99b51e733a3659d14a298731f89f1e36405608f5.

Signed-off-by: perdasilva <perdasilva@redhat.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 0b7970c3d609e1f483a0ba68f599a5ffd2e139b5
@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit a4147fc into openshift:master Jun 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@perdasilva: All pull requests linked via external trackers have merged:

Bugzilla bug 2100323 has been moved to the MODIFIED state.

In response to this:

Bug 2100323: Fix legacy registries no longer working (#974)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@anik120 anik120 Awaiting requested review from anik120

@Xia-Zhao-rh Xia-Zhao-rh Awaiting requested review from Xia-Zhao-rh

+1 more reviewer

@gallettilance gallettilance gallettilance approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@joelanford joelanford

@timflannagan timflannagan

@gallettilance gallettilance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@perdasilva @joelanford @timflannagan @gallettilance