-
Notifications
You must be signed in to change notification settings - Fork 72
Makefile: Use the full git commit hash when building binaries #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: Use the full git commit hash when building binaries #33
Conversation
Update the root Makefile and copy-paste the GIT_COMMIT from the staging/operator-lifecycle-manager/Makefile that checks if any of the ART-defined environment variables are present in the build environment, and falling back to the full git commit hash. This is important as there's existing tests in openshift/origin that verify that full commit hash is present when running the version/--version command/flags for the OLM and registry binaries.
Link to a rehearsal that caught this when attempting to promote from the downstream monorepo instead of the upstream equivalents: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/17323/rehearse-17323-pull-ci-openshift-operator-framework-olm-release-4.9-e2e-gcp/1376992350034726912. |
Need to land this before merging openshift/release #17323. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@timflannagan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Remove Bundle validator from the validator list (cherry picked from commit 363b6d81f4a8eda3f73f09fbd3fb8d655fcc6661)
Remove Bundle validator from the validator list (upstream api commit: 363b6d81f4a8eda3f73f09fbd3fb8d655fcc6661)
Remove Bundle validator from the validator list (upstream api commit: 363b6d81f4a8eda3f73f09fbd3fb8d655fcc6661)
Update the root Makefile and copy-paste the GIT_COMMIT from the
staging/operator-lifecycle-manager/Makefile that checks if any of the
ART-defined environment variables are present in the build environment,
and falling back to the full git commit hash.
This is important as there's existing tests in openshift/origin that
verify that full commit hash is present when running the
version/--version command/flags for the OLM and registry binaries.