Skip to content

OCPBUGS-1326: Opm serve cmds #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2022
Merged

OCPBUGS-1326: Opm serve cmds #382

merged 3 commits into from
Sep 15, 2022

Conversation

grokspawn
Copy link
Contributor

Earlier PR missed two lines to expose the caching commands.

joelanford and others added 3 commits September 14, 2022 09:31
@joelanford @grokspawn
opm serve: use pre-existing cache, if set and up-to-date (openshift#1005
ed5f69d 
)

* opm serve: use pre-existing cache, if set and up-to-date
* refactor to leave NewQuerier function untouched

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Upstream-commit: 494b68e62a814a891821aeb2bd28f33abc1624ff
Upstream-repository: operator-registry
@joelanford @grokspawn
do not fatally exit from serve commands (openshift#1016)
080b64c 
When we fatally exit directly in the serve functions, we do not give a
chance for the registered cleanup functions to run, resulting in
temporary files being left behind.

This commit ensures that we always cleanly return an error from the
serve function, thus ensuring that defered cleanups always happen.

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Upstream-commit: 215f413e76e3fb544b0d450acdbab41c756dbf59
Upstream-repository: operator-registry

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@grokspawn
(bug) fix permissions problems with pregen cache access (openshift#1018)
9e80ec6 
* fix permissions problems with pregen cache access
* constant replacement

Signed-off-by: Jordan <jordan@nimblewidget.com>
Upstream-commit: ce3bb44f7618726474a78f95852e30a2bfb0346a
Upstream-repository: operator-registry
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

@grokspawn: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-1326: Opm serve cmds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 14, 2022
@openshift-ci-robot
Copy link

@grokspawn: This pull request references Jira Issue OCPBUGS-1326, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-829 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-829 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Earlier PR missed two lines to expose the caching commands.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from Xia-Zhao-rh September 14, 2022 14:59
@grokspawn
Copy link
Contributor Author

/hold needs qe-approved label

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@timflannagan
Copy link
Contributor

/uncc
/unassign

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 14, 2022
awgreene
awgreene approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, grokspawn, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [awgreene,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dinhxuanvu
dinhxuanvu reviewed Sep 14, 2022
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@awgreene
Copy link
Contributor

/label backport-risk-assessed

This change is required to introduce the caching flags that enable the caching features already backported.

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 14, 2022
@grokspawn
Copy link
Contributor Author

/test unit-olm
/test e2e-gcp-olm-flaky

@grokspawn
Copy link
Contributor Author

/retest-required

@grokspawn
Copy link
Contributor Author

/test e2e-gcp-olm-flaky

2 similar comments
@grokspawn
Copy link
Contributor Author

/test e2e-gcp-olm-flaky

@grokspawn
Copy link
Contributor Author

/test e2e-gcp-olm-flaky

@Xia-Zhao-rh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 15, 2022
@Xia-Zhao-rh
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 15, 2022
@Xia-Zhao-rh
Copy link

/retest

@Xia-Zhao-rh
Copy link

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6462512 into openshift:release-4.11 Sep 15, 2022
@openshift-ci-robot
Copy link

@grokspawn: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1326 has been moved to the MODIFIED state.

In response to this:

Earlier PR missed two lines to expose the caching commands.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn grokspawn deleted the opm-serve-cmds branch September 15, 2022 01:43
@dcbw dcbw mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xia-Zhao-rh Xia-Zhao-rh Awaiting requested review from Xia-Zhao-rh

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@benluddy benluddy Awaiting requested review from benluddy

3 more reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu left review comments

@awgreene awgreene awgreene approved these changes

@timflannagan timflannagan timflannagan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@awgreene awgreene

@dinhxuanvu dinhxuanvu

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@grokspawn @openshift-ci-robot @timflannagan @awgreene @Xia-Zhao-rh @dinhxuanvu @openshift-merge-robot @joelanford