Skip to content

Rename workload annotations #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2021
Merged

Rename workload annotations #61

merged 1 commit into from
Apr 28, 2021

Conversation

lack
Copy link
Member

@lack lack commented Apr 19, 2021

As per openshift/enhancements#739, the workload
annotations names are changing.

Signed-off-by: Jim Ramsay jramsay@redhat.com

/hold
Hold until after openshift/kubernetes#632 is merged please

@lack
Rename workload annotations
8281e29 
As per openshift/enhancements#739, the workload
annotations names are changing.

Signed-off-by: Jim Ramsay <jramsay@redhat.com>
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2021
@lack
Copy link
Member Author

lack commented Apr 20, 2021

/retest

2 similar comments
@lack
Copy link
Member Author

lack commented Apr 20, 2021

/retest

@lack
Copy link
Member Author

lack commented Apr 20, 2021

/retest

@mrunalp mrunalp added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 20, 2021
@lack
Copy link
Member Author

lack commented Apr 20, 2021

/retest

1 similar comment
@lack
Copy link
Member Author

lack commented Apr 21, 2021

/retest

@imiller0
Copy link

/unhold
openshift/kubernetes#632 has now merged, please review and merge this PR as well.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2021
@lack
Copy link
Member Author

lack commented Apr 27, 2021

/assign @timflannagan

This is a minor renaming of the changes in the previous PR for this feature (#42)

@timflannagan
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lack, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2021
@lack
Copy link
Member Author

lack commented Apr 27, 2021

/retest

2 similar comments
@lack
Copy link
Member Author

lack commented Apr 27, 2021

/retest

@lack
Copy link
Member Author

lack commented Apr 28, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member Author

lack commented Apr 28, 2021

/retest

1 similar comment
@lack
Copy link
Member Author

lack commented Apr 28, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member Author

lack commented Apr 28, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member Author

lack commented Apr 28, 2021

/retest

1 similar comment
@lack
Copy link
Member Author

lack commented Apr 28, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member Author

lack commented Apr 28, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@timflannagan
Copy link
Contributor

Hmm looks like a bad Prometheus PR got merged into master accidentally due to CI testing against the wrong images.

Going to retest, but we may need to throw a hold on this until that change gets reverted.

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member Author

lack commented Apr 28, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 1751d4a into openshift:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@timflannagan timflannagan Awaiting requested review from timflannagan

Assignees

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lack @imiller0 @timflannagan @openshift-ci-robot @openshift-bot @mrunalp @openshift-merge-robot