Skip to content

OCPBUGS-49759: Revert "[release-4.18] OCPBUGS-49715: CA cert and catalog cache bug fixes" #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

oceanc80
Copy link
Contributor

@oceanc80 oceanc80 commented Feb 3, 2025

Reverts #256 due to failing singlenode jobs noted in

TRT-1985

Testing with
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 3, 2025
@openshift-ci-robot
Copy link

@oceanc80: This pull request references Jira Issue OCPBUGS-49715, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #256 due to failing singlenode jobs noted in

TRT-1985

Testing with
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 3, 2025
Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oceanc80

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@oceanc80
Copy link
Contributor Author

oceanc80 commented Feb 3, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 3, 2025
@oceanc80 oceanc80 changed the title Revert "[release-4.18] OCPBUGS-49715: CA cert and catalog cache bug fixes" OCPBUGS-49715: Revert "[release-4.18] OCPBUGS-49715: CA cert and catalog cache bug fixes" Feb 3, 2025
@oceanc80
Copy link
Contributor Author

oceanc80 commented Feb 3, 2025

/jira refresh

@openshift-ci-robot
Copy link

@oceanc80: This pull request references Jira Issue OCPBUGS-49715, which is invalid:

  • expected dependent Jira Issue OCPBUGS-49683 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@oceanc80
Copy link
Contributor Author

oceanc80 commented Feb 3, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2025
@oceanc80 oceanc80 changed the title OCPBUGS-49715: Revert "[release-4.18] OCPBUGS-49715: CA cert and catalog cache bug fixes" OCPBUGS-49759: Revert "[release-4.18] OCPBUGS-49715: CA cert and catalog cache bug fixes" Feb 3, 2025
@openshift-ci-robot
Copy link

@oceanc80: This pull request references Jira Issue OCPBUGS-49759, which is invalid:

  • expected Jira Issue OCPBUGS-49759 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #256 due to failing singlenode jobs noted in

TRT-1985

Testing with
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@oceanc80
Copy link
Contributor Author

oceanc80 commented Feb 3, 2025

/jira refresh

@openshift-ci-robot
Copy link

@oceanc80: This pull request references Jira Issue OCPBUGS-49759, which is invalid:

  • expected Jira Issue OCPBUGS-49759 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@oceanc80
Copy link
Contributor Author

oceanc80 commented Feb 3, 2025

/jira refresh

@openshift-ci-robot
Copy link

@oceanc80: This pull request references Jira Issue OCPBUGS-49759, which is invalid:

  • expected dependent Jira Issue OCPBUGS-49760 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joelanford joelanford force-pushed the revert-256-4.18-ocpbugs-49683 branch from 9ca14d0 to 36eeeb1 Compare February 3, 2025 18:15
@oceanc80
Copy link
Contributor Author

oceanc80 commented Feb 3, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 3, 2025
@openshift-ci-robot
Copy link

@oceanc80: This pull request references Jira Issue OCPBUGS-49759, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-49760 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-49760 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from Xia-Zhao-rh February 3, 2025 18:20
@oceanc80
Copy link
Contributor Author

oceanc80 commented Feb 3, 2025

/lgtm
/unhold

Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

@oceanc80: you cannot LGTM your own PR.

In response to this:

/lgtm
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2025
@dtfranz
Copy link
Contributor

dtfranz commented Feb 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
@bandrade
Copy link

bandrade commented Feb 3, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 3, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 859b4d2 and 2 for PR HEAD 36eeeb1 in total

@neisw
Copy link
Contributor

neisw commented Feb 3, 2025

/override ci/prow/openshift-e2e-aws

unrelated to the revert

Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

@neisw: Overrode contexts on behalf of neisw: ci/prow/openshift-e2e-aws

In response to this:

/override ci/prow/openshift-e2e-aws

unrelated to the revert

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@neisw
Copy link
Contributor

neisw commented Feb 3, 2025

/skip

@openshift-merge-bot openshift-merge-bot bot merged commit 7aefe70 into release-4.18 Feb 3, 2025
9 checks passed
@openshift-ci-robot
Copy link

@oceanc80: Jira Issue OCPBUGS-49759: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-49759 has been moved to the MODIFIED state.

In response to this:

Reverts #256 due to failing singlenode jobs noted in

TRT-1985

Testing with
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

@oceanc80: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 36eeeb1 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@oceanc80 oceanc80 deleted the revert-256-4.18-ocpbugs-49683 branch February 3, 2025 21:46
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-operator-controller
This PR has been included in build ose-olm-operator-controller-container-v4.18.0-202502032201.p0.g7aefe70.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.