Skip to content

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jul 10, 2025

Follow up of: #383
We missed a check-metadata which was added in the review, and we convey that we cannot do this check so far, and I missed the cleanup before getting merged

~/go/src/github/operator-framework-operator-controller/openshift/tests-extension (fix-remove-target) $ make verify
go mod tidy
go fmt ./...
go vet ./...
/Users/camilam/go/bin/golangci-lint-v2.1.6 run
0 issues.

NOTE: After this fix, we can enable it in the CI and avoid errors: openshift/release#66931

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request explicitly references no jira issue.

In response to this:

Follow up of: #383
We missed a check-metadata which was added in the review, and we convey that we cannot do this check so far, and I missed the cleanup before getting merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 changed the title NO-ISSUE: UPSTREAM: <carry>: [OTE] - chore: follow up #383 – remove unreachable target call OPRUN-3963: UPSTREAM: <carry>: [OTE] - chore: follow up #383 – remove unreachable target call Jul 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 10, 2025

@camilamacedo86: This pull request references OPRUN-3963 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Follow up of: #383
We missed a check-metadata which was added in the review, and we convey that we cannot do this check so far, and I missed the cleanup before getting merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 changed the title OPRUN-3963: UPSTREAM: <carry>: [OTE] - chore: follow up #383 – remove unreachable target call OPRUN-3963: UPSTREAM: <carry>: [OTE] - chore: follow up #383 – fix make verify Jul 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 10, 2025

@camilamacedo86: This pull request references OPRUN-3963 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Follow up of: #383
We missed a check-metadata which was added in the review, and we convey that we cannot do this check so far, and I missed the cleanup before getting merged

~/go/src/github/operator-framework-operator-controller/openshift/tests-extension (fix-remove-target) $ make verify
go mod tidy
go fmt ./...
go vet ./...
/Users/camilam/go/bin/golangci-lint-v2.1.6 run
0 issues.

NOTE: After this fix, we can enable it in the CI and avoid errors: openshift/release#66931

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Contributor

tmshort commented Jul 10, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2025
Copy link
Contributor

openshift-ci bot commented Jul 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 35faa6b and 2 for PR HEAD 61b965e in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 35faa6b and 2 for PR HEAD 61b965e in total

@camilamacedo86
Copy link
Contributor Author

/test openshift-e2e-aws

1 similar comment
@camilamacedo86
Copy link
Contributor Author

/test openshift-e2e-aws

Copy link
Contributor

openshift-ci bot commented Jul 11, 2025

@camilamacedo86: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openshift-e2e-aws-techpreview 61b965e link false /test openshift-e2e-aws-techpreview
ci/prow/okd-scos-e2e-aws-ovn 61b965e link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cba0e4c into openshift:main Jul 11, 2025
9 of 11 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-operator-controller
This PR has been included in build ose-olm-operator-controller-container-v4.20.0-202507110814.p0.gcba0e4c.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-catalogd
This PR has been included in build ose-olm-catalogd-container-v4.20.0-202507110814.p0.gcba0e4c.assembly.stream.el9.
All builds following this will include this PR.

@camilamacedo86 camilamacedo86 deleted the fix-remove-target branch July 11, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants