Revert "OCPBUGS-60564: [OTE] Add webhook to validate openshift-service-ca certificate rotation" #455
Conversation
openshift-ci-robot
added
jira/severity-important
|
@neisw: This pull request references Jira Issue OCPBUGS-60564, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
neisw
force-pushed
the
revert-450-add-webhook-tolerance-test
branch
from
e8cf45e to
9068488
Compare
|
/lgtm |
|
@neisw, I'm not seeing a failure of this test in the provided link; in fact the test is listed in the "Tests Pass" (not that those seem to matter, given 0s run time). Which seems like a build problem? I'm not clear on the reasoning for that error or this revert. |
|
Note: The prefix for this commit is |
|
@neisw: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@tmshort it isn't that the test is failing but that it is causing other failures. Sippy intervals can help show that but also the PR being reverted had these failures in the payload jobs used for verification. |
…tion test, mirroring the logic used in the certificate rotation test. This makes the test more robust by ensuring a new secret is created, not just that an existing one is still present. This reverts commit 0bb1953. UPSTREAM: <carry>: [OTE] Add webhook to validate openshift-service-ca certificate rotation This reverts commit e9e3220.
neisw
force-pushed
the
revert-450-add-webhook-tolerance-test
branch
from
9068488 to
7ff0655
Compare
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@tmshort: This pull request references Jira Issue OCPBUGS-60564, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (bandrade@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial 2 |
|
/lgtm |
|
@tmshort: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0c0104f0-81c1-11f0-8ae5-ba8b9934ac5c-0 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neisw, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override ci/prow/e2e-aws-techpreview-olmv1-ext passed previously but had to update the commit message |
|
@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-techpreview-olmv1-ext, ci/prow/okd-scos-e2e-aws-ovn, ci/prow/openshift-e2e-aws, ci/prow/openshift-e2e-aws-techpreview In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@neisw: Jira Issue OCPBUGS-60564: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-60564 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Reverts #450
Failures seen in pr /payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial 10 are now seen in payloads.