OPRUN-4160: Fix cp-manifests copying of helm charts #482
Conversation
The method used to copy the helm charts is including an extra `helm` directory in the destination path, that is making the cluster-olm-operator code just a bit more complicated than it needs to be. This fixes the copy location. Signed-off-by: Todd Short <todd.short@me.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@tmshort: This pull request references OPRUN-4160 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/verified by @bandrade |
openshift-ci
bot
added
the
qe-approved
|
@tmshort: This pull request references OPRUN-4160 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
verified
|
@bandrade: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
I didn't get a sense of how exactly the cluster-olm-operator code is getting complicated and how this fix alleviates that problem from the PR itself, but the change does what the PR's intention is (ie copy contents of the helm directory into catalogd, instead of copying the helm directory itself). so
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah, it's the extra directory, and it's a WIP PR, so you probably haven't noticed it yet. |
|
(This has no impact on the current cluster-olm-operator, just the one I'm working on.) |
|
This got all the way to deprovision and then failed... |
|
/retest-required |
|
/test openshift-e2e-aws-techpreview |
|
/retest-required |
|
/test openshift-e2e-aws-techpreview |
|
/test openshift-e2e-aws |
|
/retest |
|
/retest-required |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
|
@tmshort: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 77ab3fd
into
openshift:main
The method used to copy the helm charts is including an extra
helmdirectory in the destination path, that is making the cluster-olm-operator code just a bit more complicated than it needs to be.This fixes the copy location.