-
Notifications
You must be signed in to change notification settings - Fork 31
OCPBUGS-62722: (cherry-pick) Fix truncate large error messages and unhandle changes for crd upgrade safety in status conditions #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…itions (#2169) When upgrading operators, CRD validation errors can be very large (50KB+). Kubernetes rejects status updates over 32KB with "Too long: may not be more than 32768 bytes". This causes ClusterExtension upgrades to fail and get stuck. Assisted-by: Cursor
…CPBUGS-59518 ) (#2179) * (fix): unhandle changes for crd upgrade safety - Keep unhandled spec changes as errors; message: "unhandled changes found" Assisted-by: Cursor * enhance to extract details from unhandle issue
@camilamacedo86: This pull request references Jira Issue OCPBUGS-62722, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@camilamacedo86: This pull request references Jira Issue OCPBUGS-62722, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@camilamacedo86: This pull request references Jira Issue OCPBUGS-62722, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@camilamacedo86: This pull request references Jira Issue OCPBUGS-62722, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@camilamacedo86: This pull request references Jira Issue OCPBUGS-62722, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label qe-approved |
@camilamacedo86: This pull request references Jira Issue OCPBUGS-62722, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@bandrade: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
Still have a problem in techpreview |
/test openshift-e2e-aws-techpreview |
@camilamacedo86: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label backport-risk-assessed |
0df53a9
into
openshift:release-4.20
@camilamacedo86: Jira Issue OCPBUGS-62722: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-62722 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Description
ClusterExtension upgrade could fail due to oversized CRD validation status updates
When upgrading a ClusterExtension, CRD validation status updates could exceed the Kubernetes 32 KB limit, causing the update to fail with the error “Too long: may not be more than 32768 bytes.” This prevented the ClusterExtension status from being updated, leaving no status conditions or information about why the upgrade did not occur.
This issue occurred when the crddiff library returned a large JSON diff for unhandled CRD changes.
The problem has been resolved by truncating and summarising the diff output for unhandled scenarios, instead of including the full JSON diff. This ensures status updates remain within size limits and users receive clear, actionable error messages.
Cherry-picks
More info
To address the fix verified for
4.21
to4.20
( version where the bug was reported initially).More info: https://issues.redhat.com/browse/OCPBUGS-59518?focusedId=28188598&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-28188598