-
Notifications
You must be signed in to change notification settings - Fork 31
OCPBUGS-22616: [release-4.14] Bump go.opentelemetry.io dependencies #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-22616: [release-4.14] Bump go.opentelemetry.io dependencies #58
Conversation
@ankitathomas: This pull request references Jira Issue OCPBUGS-22616, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
0c04c83
to
ec2a98a
Compare
/jira refresh |
@ankitathomas: This pull request references Jira Issue OCPBUGS-22616, which is valid. The bug has been moved to the POST state. 8 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ankitathomas please update your commit message to start with |
ec2a98a
to
c4b0914
Compare
/label backport-risk-assessed |
Signed-off-by: Ankita Thomas <ankithom@redhat.com>
c4b0914
to
e1c4557
Compare
@ankitathomas: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label qe-approved |
@ankitathomas: This pull request references Jira Issue OCPBUGS-22616, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label cherry-pick-approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a corresponding PR to operator-framework/operator-controller that makes/made this change? We'd want the prefix to be
UPSTREAM: 1234
with 1234 being replaced with whatever the upstream PR was. If there isn't an upstream PR, we should probably have one?
We have operator-framework/operator-controller#557 which bumps go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp
amongst other things. However it doesn't look like we will be able to cherry-pick the relevant commit into 4.14 downstream branch.
As far as I understand, in this case it should be a <carry>
(as it is right now). So it looks good to me.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, awgreene, m1kola The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ankitathomas: Jira Issue OCPBUGS-22616: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-22616 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-olm-operator-controller-container-v4.14.0-202312211913.p0.gd714b46.assembly.stream for distgit ose-olm-operator-controller. |
No description provided.