This repository was archived by the owner on Aug 29, 2018. It is now read-only.
Revert "we do not want %ghost-ed log files" #6025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0550ff7. We do in fact want the log files to be %ghost so they are not overwritten on every update. Bug 1134578 - The Broker's user_action.log should not be overwritten on RPM upgrade https://bugzilla.redhat.com/show_bug.cgi?id=1134578
|
[merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6238/) (Image: devenv_5365) |
|
Evaluated for online up to 1585233 |
|
Broker %post has code to create the log files with correct perms at install, to prevent someone running oo-commands as root that create them with the wrong ones. Console and node %post don't do this, but they don't really need to because there is basically no chance the log files will be created with the wrong permissions. |
openshift-bot
pushed a commit
that referenced
this pull request
Dec 17, 2014
Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0550ff7.
We do in fact want the log files to be %ghost so they are not
overwritten on every update.
Bug 1134578 - The Broker's user_action.log should not be overwritten on RPM upgrade
https://bugzilla.redhat.com/show_bug.cgi?id=1134578